Add a 'createdAt' time when persisting new Iconik projects#1507
Merged
Add a 'createdAt' time when persisting new Iconik projects#1507
Conversation
bryophyta
force-pushed
the
pf/add-createdAt-to-iconik-projects-model
branch
from
387d05d to
6f262f4
Compare
andrew-nowak
reviewed
Apr 8, 2026
Comment on lines
+100
to
+103
| createdAt = Some( | ||
| createdAt | ||
| .format(java.time.format.DateTimeFormatter.ISO_DATE_TIME) | ||
| ) |
Member
There was a problem hiding this comment.
Won't this replace the createdAt time every time a project is upserted? ie. this field would be a lastModifiedAt
Contributor
Author
There was a problem hiding this comment.
yes it would. I did wonder about this but convinced myself it was fine because I don't think we have any expectation of a project being upserted more than once, as it stands.
but on reflection I think you're right 👍 I'll take a look at this later
Contributor
Author
There was a problem hiding this comment.
added a new commit which should address this: 9ecf022
bryophyta
force-pushed
the
pf/add-createdAt-to-iconik-projects-model
branch
from
c2fd054 to
9ecf022
Compare
andrew-nowak
approved these changes
Apr 13, 2026
bryophyta
force-pushed
the
pf/add-createdAt-to-iconik-projects-model
branch
from
9ecf022 to
9f8b70c
Compare
|
Seen on PROD (merged by @bryophyta 5 minutes and 31 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Add a 'created at' time when we store new Iconik projects. This is an optional field, so it shouldn't cause any issues for existing projects. The main use-case that we're anticipating at the moment is that it will allow ordering or filtering by time created. Generally speaking, the value in this is to surface the most recent projects first. So that means we can afford to defer the question of whether/how to backfill the creation date for old projects.
How has this change been tested?
How can we measure success?
Have we considered potential risks?
Images
Accessibility