Remove contact#2
Open
karldelandsheere wants to merge 11 commits into
Open
Conversation
Add a method to remove a contact from the contacts table by specifying their id.
Changed the query parameter to target a contact with their public_key instead of their id, so the feedback message will be more meaningful.
Added the methods, bindings, etc for contact removal.
Yeah no, I re-read the code and it's better to use node_id. I'll see later for the feedback message.
Added a binding for "remove contact"
Added classes for removing a contact
Forgot to replace a parameter. Fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added the feature to remove a contact. Cheers!