Explicitly include RSA key exchange AES cipher suites in TLS client config#41
Merged
riccardo-perotti merged 2 commits intoApr 17, 2026
Conversation
…onfig Go 1.22+ removed RSA key exchange cipher suites from the default client cipher suite list (GODEBUG tlsrsakey=0). This breaks connections to internal Go services built with older toolchains (e.g. gt-auth-service) that only offer RSA key exchange suites, resulting in an immediate EOF. Fix by appending the four RSA+AES suites to the modern defaults. RC4 and 3DES are intentionally excluded. This is appropriate given InsecureSkipVerify is already set on these internal SCAMP connections. JiraID: ROP-9188 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…commit JiraID: ROP-9188 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
riccardo-perotti
deleted the
rp.ROP-9188.explicitly-include-rsa-cipher-suites-in-the-tls-config
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GODEBUG tlsrsakey=0)gt-auth-service) only offer RSA key exchange suites, causing an immediateEOFwhen a Go 1.22+ client connectsDialConnectionCipher suites added:
TLS_RSA_WITH_AES_128_GCM_SHA256TLS_RSA_WITH_AES_256_GCM_SHA384TLS_RSA_WITH_AES_128_CBC_SHATLS_RSA_WITH_AES_256_CBC_SHAThese lack forward secrecy but are not cryptographically broken. They are appropriate given
InsecureSkipVerifyis already set on these internal SCAMP connections.Long-term:
gt-auth-serviceshould be upgraded to a modern Go version so it offers ECDHE cipher suites.Jira Tickets
https://gudtech.atlassian.net/browse/ROP-9188
🤖 Generated with Claude Code