Release v2.4.2#237
Closed
tig wants to merge 16 commits into
Closed
Conversation
Back-merge v2.4.1 from main into develop
BREAKING CHANGE: All namespaces in the Editor assembly are now rooted under Terminal.Gui.Editor.*: - Terminal.Gui.Document -> Terminal.Gui.Editor.Document - Terminal.Gui.Document.Folding -> Terminal.Gui.Editor.Document.Folding - Terminal.Gui.Document.Search -> Terminal.Gui.Editor.Document.Search - Terminal.Gui.Document.Utils -> Terminal.Gui.Editor.Document.Utils - Terminal.Gui.Highlighting -> Terminal.Gui.Editor.Highlighting - Terminal.Gui.Highlighting.Xshd -> Terminal.Gui.Editor.Highlighting.Xshd - Terminal.Gui.Text.Indentation -> Terminal.Gui.Editor.Indentation Consumers must update using directives when upgrading. Closes #231 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReSharper sorts Terminal.Gui.Editor.* after Terminal.Gui.Drawing/Input alphabetically, which changed relative positions after the rename. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add MarkdownPreview subclass of Markdown that: - Highlights the rendered line corresponding to the editor's current source line using a proportional mapping and background color shift - Raises SourceLineClicked when user clicks in the preview, enabling click-to-navigate back to the corresponding source line in the editor Wire up Editor.CaretChanged in TedApp to update the highlight on every caret move, and handle SourceLineClicked to move the editor caret. Closes #229 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
One type per file per CLAUDE.md convention. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…l-gui-edito refactor!: move all namespaces under Terminal.Gui.Editor
…espaces Add NamespaceDoc.cs files to each namespace folder so that DocFX generates namespace summaries in the API reference. Documentation content is drawn from README.md descriptions. Namespaces documented: - Terminal.Gui.Editor (root, with hero.gif image) - Terminal.Gui.Editor.Completion - Terminal.Gui.Editor.Document - Terminal.Gui.Editor.Document.Folding - Terminal.Gui.Editor.Document.Search - Terminal.Gui.Editor.Document.Utils - Terminal.Gui.Editor.Highlighting - Terminal.Gui.Editor.Highlighting.Xshd - Terminal.Gui.Editor.Indentation - Terminal.Gui.Editor.Rendering Closes #230 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes incorrect highlight painting when Viewport.X > 0 (horizontal scroll). ContentToScreen gave content-relative screen coords that shifted the read position; ViewportToScreen correctly maps the viewport-relative draw row to screen buffer coordinates. Also fixes CRLF line endings in SourceLineClickedEventArgs.cs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-indicator feat(ted): highlight current editor line in Markdown preview
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fixes #235. Bug: CRLF newline requires two keypresses
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add namespace-level XML documentation for all Terminal.Gui.Editor namespaces
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c033cb3ccf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| using System.Threading.Tasks; | ||
|
|
||
| namespace Terminal.Gui.Document | ||
| namespace Terminal.Gui.Editor.Document |
There was a problem hiding this comment.
Renaming core public types from Terminal.Gui.Document to Terminal.Gui.Editor.Document in a patch release breaks both source and binary compatibility for existing consumers (e.g., code using TextDocument via the old namespace will stop compiling, and already-built apps can fail type resolution at runtime after upgrade). This commit does not include compatibility shims/type forwarders, so upgrading from 2.4.1 to 2.4.2 becomes a breaking change rather than a safe patch update.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v2.4.2
Version:
2.4.2NuGet Package:
Terminal.Gui.Editor 2.4.2What happens when this PR is merged
v2.4.2Terminal.Gui.Editor 2.4.2to NuGet.orgmain->developis openedChecklist
2.4.2