Release v2.5.3#249
Conversation
Back-merge v2.5.2 from main into develop
Editor's package version is now computed from git tags by GitVersion 6 (same GitFlow model TG uses) instead of a hand-maintained <Version> base that had already gone stale (develop prereleases 2.4.1-develop.N sorted below the published 2.5.2 stable). - GitVersion.yml: tag-driven versions; develop = 2.5.3-develop.N - release.yml: resolve-version via GitVersion (tags still strip 'v') - prepare-release.yml: default version from GitVersion MajorMinorPatch; gate stable releases on a stable TerminalGuiVersion pin (NU5104) - bump-terminal-gui.yml: auto-bump the TG pin on TG publishes (dispatch/schedule/manual); green -> commit to develop, red -> PR - Directory.Build.targets: -p:UseLocalTerminalGui=true swaps the TG PackageReference for a ProjectReference into ../Terminal.Gui (blocked in CI and for pack) - TerminalGuiVersion 2.4.0 -> 2.4.6-develop.9; tests now use Glyphs.CheckStateChecked/UnChecked instead of hardcoded glyphs (TG changed the checked-menu glyph upstream) - CLAUDE.md + specs/decisions.md DEC-010 document the model Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A dispatch from TG's publish workflow can arrive before the version is restorable on flat-container; restore failure would mis-report breakage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The committed gitlink had no .gitmodules entry, so every CI checkout's post-job cleanup failed with git exit 128 warnings. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5af2f66da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [ -n "$EXPLICIT" ]; then | ||
| TARGET="$EXPLICIT" | ||
| else |
There was a problem hiding this comment.
When this workflow is triggered by repository_dispatch, the payload version is accepted as TARGET solely because it is present. If Terminal.Gui publishes multiple versions close together or GitHub queues/delivers dispatch runs out of order, a later run for an older payload (for example 2.4.6-develop.9 after the pin has already advanced to 2.4.6-develop.17) will pass the TARGET != CURRENT check and commit a downgrade to develop, publishing Editor against an older dependency. Please compare TARGET and CURRENT semver order for dispatch/manual values and skip non-advancing targets.
Useful? React with 👍 / 👎.
1 participant
Release v2.5.3
Version:
2.5.3NuGet Package:
Terminal.Gui.Editor 2.5.3What happens when this PR is merged
v2.5.3Terminal.Gui.Editor 2.5.3to NuGet.orgmain->developis openedChecklist
2.5.3