Include all messages for the original language in the react-intl output#19
Open
rescribet wants to merge 1 commit into
Open
Include all messages for the original language in the react-intl output#19rescribet wants to merge 1 commit into
rescribet wants to merge 1 commit into
Conversation
Contributor
Author
|
This works again after rebasing on master. @guigrpa What do you think of the behaviour, should it be behind a flag? |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First off, awesome project. It makes working with react-intl a lot easier, especially for small scale translations (in comparison to react-intl-translations-manager + serge + pootle).
When trying this library to build the message bundles for react-intl, I noticed the file for the original language only contained the default message when an interpolation was given.
I figured since the messages are the defaults and therefore already in the code one might one of two things;
config.langsor disregard the outputted<defaultLang>.reactIntl.jsonfile.This PR shouldn't change behaviour for the first case, but it'll make the second case possible