chore: desktop release alignment + CI fixes #1
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,7 +139,7 @@ CSS em: `ui/src/styles/chat/grouped.css` (classes `.msg-meta__*`) | |
|
|
||
| ### 4.1 Parser de historico | ||
|
|
||
| Arquivo: `desktop/renderer/src/store/slices/chat/chat-utils.ts` | ||
|
|
||
| O `parseHistoryMessages()` extrai `usage` e `model` de cada mensagem raw: | ||
|
|
||
|
|
@@ -163,7 +163,7 @@ const messageModel = | |
|
|
||
| ### 4.2 Tipos | ||
|
|
||
| Arquivo: `desktop/renderer/src/store/slices/chat/chat-types.ts` | ||
|
|
||
| ```typescript | ||
| type UiMessageUsage = { | ||
|
|
@@ -182,12 +182,12 @@ type UiMessage = { | |
|
|
||
| ### 4.3 Componente de renderizacao | ||
|
|
||
| Arquivo: `desktop/renderer/src/ui/chat/components/MessageMeta.tsx` | ||
|
|
||
| Renderiza inline abaixo de cada mensagem do assistente: | ||
|
|
||
| ``` | ||
| OpenSpace 13:40 ↑4k ↓371 R26k W212 claude-opus-4-6 | ||
| ``` | ||
|
Comment on lines
189
to
191
There was a problem hiding this comment. Add language specifier to fenced code block. The code block at line 189 is missing a language specifier. Since it shows rendered UI output text, consider using 📝 Suggested fix-```
+```text
OpenSpace 13:40 ↑4k ↓371 R26k W212 claude-opus-4-6🧰 Tools🪛 markdownlint-cli2 (0.22.0)[warning] 189-189: Fenced code blocks should have a language specified (MD040, fenced-code-language) 🤖 Prompt for AI Agents |
||
|
|
||
| Props recebidas diretamente da mensagem: | ||
|
|
@@ -200,7 +200,7 @@ Fallback: se `model` nao vier na mensagem, le do config (`agents.defaults.model. | |
|
|
||
| ### 4.4 Integracao no ChatMessageList | ||
|
|
||
| Arquivo: `desktop/renderer/src/ui/chat/components/ChatMessageList.tsx` | ||
|
|
||
| ```tsx | ||
| { | ||
|
|
@@ -226,19 +226,19 @@ Arquivo: `apps/electron-desktop/renderer/src/ui/chat/components/ChatMessageList. | |
| ↓ | ||
| [Redux Store] → UiMessage com usage/model | ||
| ↓ | ||
| [MessageMeta] → renderiza inline: "OpenSpace 13:40 ↑4k ↓371 R26k claude-opus-4-6" | ||
| ``` | ||
|
|
||
| --- | ||
|
|
||
| ## 6. Referencia de arquivos | ||
|
|
||
| | Arquivo | Responsabilidade | | ||
| | ---------------------------------------------------------------- | ---------------------------------------- | | ||
| | `ui/src/ui/chat/grouped-render.ts` | Control UI — extrai e renderiza metadata | | ||
| | `ui/src/styles/chat/grouped.css` | Control UI — estilos `.msg-meta__*` | | ||
| | `desktop/renderer/src/store/slices/chat/chat-types.ts` | Tipos `UiMessageUsage`, `UiMessage` | | ||
| | `desktop/renderer/src/store/slices/chat/chat-utils.ts` | Parser `parseHistoryMessages()` | | ||
| | `desktop/renderer/src/ui/chat/components/MessageMeta.tsx` | Componente de metadata inline | | ||
| | `desktop/renderer/src/ui/chat/components/MessageMeta.module.css` | Estilos do MessageMeta | | ||
| | `desktop/renderer/src/ui/chat/components/ChatMessageList.tsx` | Integracao do MessageMeta nas mensagens | | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Windows installer path is only tested on release tags.
Line 14 still hardcodes
verifytomacos-latest, and Line 54 only runs--mac zip, while Line 77 introduces the Windows NSIS target only in the tag-gatedreleasematrix. That makes av*tag the first time the Windows packaging path runs, so NSIS/path/signing regressions can land onmainunnoticed and fail only during release.💡 Suggested smoke-build matrix for
verifyverify: if: github.event_name != 'push' || !startsWith(github.ref, 'refs/tags/v') - runs-on: macos-latest + strategy: + fail-fast: false + matrix: + include: + - os: macos-latest + smoke_args: --mac zip + artifact_name: openspace-smoke-mac + - os: windows-latest + smoke_args: --win nsis + artifact_name: openspace-smoke-win + runs-on: ${{ matrix.os }} @@ - name: Package smoke build env: CSC_IDENTITY_AUTO_DISCOVERY: false - run: cd desktop && npx electron-builder --publish never --mac zip + run: cd desktop && npx electron-builder --publish never ${{ matrix.smoke_args }} @@ - name: Upload smoke artifacts uses: actions/upload-artifact@v4 with: - name: openspace-smoke-mac-${{ github.sha }} + name: ${{ matrix.artifact_name }}-${{ github.sha }}Also applies to: 51-55, 69-79
🤖 Prompt for AI Agents