Skip to content

Fix treating untyped parameter as K & R variadic #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gulugulubing merged 2 commits into from
Jun 8, 2026
Merged

Fix treating untyped parameter as K & R variadic #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6024830
Fix untyped K&R parameter
ntrel Jun 8, 2026
8f5ec86
Use C23 variadic syntax
ntrel Jun 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions compiler/src/dmd/hdrgen.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3656,6 +3656,13 @@ const(char)* parameterToChars(Parameter parameter, TypeFunction tf, bool fullQua
private void parametersToBuffer(ParameterList pl, ref OutBuffer buf, ref HdrGenState hgs)
{
buf.put('(');
if (pl.varargs == VarArg.KRvariadic)
{
if (!hgs.hdrgen)
buf.put("..."); // essentially C23 variadic with no named parameter
buf.put(')');
return;
}
foreach (i; 0 .. pl.length)
{
if (i)
Expand All @@ -3665,12 +3672,7 @@ private void parametersToBuffer(ParameterList pl, ref OutBuffer buf, ref HdrGenS
final switch (pl.varargs)
{
case VarArg.none:
break;

case VarArg.KRvariadic:
// Diagnostic-only spelling; header/.di output keeps plain `()`.
if (!hgs.hdrgen)
buf.put("<K&R variadics>");
break;

case VarArg.variadic:
Expand Down
8 changes: 4 additions & 4 deletions compiler/test/fail_compilation/diag23177.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
TEST_OUTPUT:
---
fail_compilation/diag23177.d(25): Error: function `run1` is not callable using argument types `(extern (C) int function())`
fail_compilation/diag23177.d(25): cannot pass argument `& callback` of type `extern (C) int function()` to parameter `extern (C) int function(<K&R variadics>) fn`
fail_compilation/imports/imp23177.c(4): `imp23177.run1(extern (C) int function(<K&R variadics>) fn)` declared here
fail_compilation/diag23177.d(26): Error: function `run2` is not callable using argument types `(extern (C) int function(int a<K&R variadics>))`
fail_compilation/diag23177.d(26): cannot pass argument `& f` of type `extern (C) int function(int a<K&R variadics>)` to parameter `extern (C) int function(int a) fn`
fail_compilation/diag23177.d(25): cannot pass argument `& callback` of type `extern (C) int function()` to parameter `extern (C) int function(...) fn`
fail_compilation/imports/imp23177.c(4): `imp23177.run1(extern (C) int function(...) fn)` declared here
fail_compilation/diag23177.d(26): Error: function `run2` is not callable using argument types `(extern (C) int function(...))`
fail_compilation/diag23177.d(26): cannot pass argument `& f` of type `extern (C) int function(...)` to parameter `extern (C) int function(int a) fn`
fail_compilation/imports/imp23177.c(14): `imp23177.run2(extern (C) int function(int a) fn)` declared here
---
*/
Expand Down
Loading