Conversation
|
This detects the OS and uses the appropriate method to add links for the compiled shared library. I couldn't get this to compile on macOS 12.0.1 as |
For use with languages like Python when compiled to a shared library. LibSWIFFT_Compute takes the output as a param, but this function will return the result for wrappers.
|
@breadbored, thanks for submitting a PR. Both portability and supporting wrappers are good goals to aim for. Regarding the portability part, could you post logs of the builds you tried on each platform to support this part of the change? The wrapping part of the change cannot be accepted, though, as it has a bug (see the commit review) and the natural solution is to use an already existing LibSWIFFT function. |
|
I cannot believe I missed this PR! I've been flooded with work PRs and it got lost in the weeds. I'll set a reminder to rebuild this weekend and I can describe what this PR aims to resolve. |
I was attempting to expose the library to Python at the time, but introduced an error referenced in gvilitechltd/LibSWIFFT PR#44.
|
@breadbored, the code-removal in the last commit looks OK. Reminder - could you post logs of the builds you tried on each platform to support the change? |
No description provided.