Address mapping enhancement and bug fix for floonoc#80
Open
liyinrong wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the FlooNoc model/generator to improve mapping flexibility and to fix a request/response classification bug in the network interface request enqueuing path.
Changes:
- Fix request-vs-response handling in
NetworkQueue::enqueue_router_reqby using the explicitis_reqparameter. - Extend the FlooNoc Python generator
o_MAPhelper to accept an optional mapping name and use it as the mapping key.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
pulp/floonoc/floonoc_network_interface.cpp |
Uses is_req to decide whether to compute destination from address mappings vs. reuse existing routing metadata. |
pulp/floonoc/floonoc.py |
Adds optional name to o_MAP and changes the mapping key selection to allow custom naming. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
151
to
153
| def o_MAP(self, base: int, size: int, | ||
| x: int, y: int, | ||
| x: int, y: int, name: str | None=None, | ||
| rm_base: bool=False, remove_offset:int =0): |
| if rm_base and remove_offset == 0: | ||
| remove_offset =base | ||
| self.__add_mapping(f"ni_{x}_{y}", base=base, size=size, x=x, y=y, remove_offset=remove_offset) | ||
| self.__add_mapping(f"ni_{x}_{y}" if name is None else name, base=base, size=size, x=x, y=y, remove_offset=remove_offset) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.