Skip to content

Feature/add tag page#15

Open
DanilZhovt wants to merge 80 commits intomasterfrom
feature/add-tag-page
Open

Feature/add tag page#15
DanilZhovt wants to merge 80 commits intomasterfrom
feature/add-tag-page

Conversation

@DanilZhovt
Copy link
Copy Markdown

@DanilZhovt DanilZhovt commented Jun 22, 2025

image (5)
image (4)
image (3)
image (6)

@DanilZhovt DanilZhovt requested a review from gvterechov June 22, 2025 19:30
Comment thread app/controllers/expressions/expressions_controller.rb Outdated
Comment thread app/controllers/expressions/expressions_controller.rb Outdated
Comment thread app/controllers/expressions/expressions_controller.rb Outdated
Comment thread app/models/expression_task_tag.rb Outdated
Comment thread app/views/common/_tags_table.html.erb Outdated
Comment thread config/routes.rb Outdated
Comment thread semantic.json Outdated
Comment thread app/models/ability.rb Outdated
Comment thread app/models/ability.rb Outdated
Comment thread app/models/ability.rb Outdated
private

def basic_can
can :manage, TaskTag, user_id: user.id
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а просматривать список своих задач и их статистику авторизованный точно сейчас может?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, может

redirect_to tags_path
end

def destroy
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мне кажется что любое действие в этом контроллере разрешено для авторизованного пользователя, вне зависимости от роли. судя по документации, на помощь могут придти подходящие хелперы контроллера

Comment thread app/models/role.rb Outdated
Comment thread config/locales/ru.yml Outdated
Comment thread config/locales/ru.yml Outdated
Comment thread config/locales/ru.yml Outdated
Comment thread config/locales/words_order.en.yml Outdated
Comment thread db/migrate/20250628114020_create_roles.rb Outdated
Comment thread app/models/expression_task.rb Outdated
Comment thread config/locales/ru.yml
Comment thread config/locales/ru.yml Outdated
Comment thread test/controllers/publications_controller_test.rb Outdated
Comment thread app/controllers/publications_controller.rb Outdated
Comment thread app/controllers/users_controller.rb
Comment thread app/models/publication.rb
Comment thread app/views/common/_tags_table.html.erb Outdated
Comment thread app/views/common/_task_statistic_table.html.erb Outdated
Comment thread app/views/common/_new_tag.html.erb Outdated
Comment thread config/locales/ru.yml Outdated
Comment thread app/models/publication.rb Outdated
Comment thread app/controllers/expressions/tasks_controller.rb Outdated
Comment thread test/controllers/publications_controller_test.rb Outdated
@DanilZhovt
Copy link
Copy Markdown
Author

DanilZhovt commented Jul 10, 2025

Не работает rich_text_area. Я думаю, что это из-за того, что не подгружаются стили и js-скрипты для ActionText и Trix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants