Conversation
…ng distributions when acl isn't declared
anjosluc
force-pushed
the
fix/avoid-webacl-conflicts
branch
from
74ff8b2 to
b591e8c
Compare
LCaparelli
approved these changes
Aug 21, 2025
2 tasks
anjosluc
added a commit
that referenced
this pull request
Aug 21, 2025
* [skip ci] chore: Add catalog-info.yaml * Revert "Create backstage-journeys file" * [PE1-4466] fix(webacl-conflicts): Ignoring webacl overrides on existing distributions when acl isn't declared (#124) * fix(webacl-conflicts): [PE1-4466] Ignoring webacl overrides on existing distributions when acl isn't declared * fix(webacl-conflicts): [PE1-4466] Fix README.md * fix(webacl-conflicts): [PE1-4466] Fixing panic when there's no distARN to be reconciled (#126) --------- Co-authored-by: gympass-backstage[bot] <147523283+gympass-backstage[bot]@users.noreply.github.com> Co-authored-by: Rubens Saraiva <rubens.saraiva@gmail.com> Co-authored-by: Caio Almeida <caio.f.r.amd@gmail.com> Co-authored-by: Lucas Caparelli <23405112+LCaparelli@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changing default behavior on distribution reconciliations for ingresses without/empty
cdn-origin-controller.gympass.com/cf.web-acl-arnannotation to keep the current distribution configuration, to avoid conflicts with externally managed Web ACL associations. RemovingCF_AWS_WAFenvironment variable to not set any default WebACL on distributions.Motivation and Context
PE1-4466
How has this been tested?
Automated tests + manual validation
Checklist