pull lastest upsteam main#36
Merged
Merged
Conversation
…inference (jonwiggins#463) * fix: gemini agent — settings validation, parser crash, and exit code inference Three bugs preventing Gemini tasks from running end-to-end: - settings.json rejected "yolo" as defaultApprovalMode (valid values are 'default' | 'auto_edit' | 'plan'); mapped to "auto_edit" since yolo mode is still applied via the --approval-mode CLI flag - tool_result events with undefined output crashed the parser because JSON.stringify(undefined) returns undefined rather than a string - inferExitCode matched the bare string "GEMINI_API_KEY" as an auth error, causing false positives; now requires error-descriptive context words Also adds gemini and openclaw to AgentTypeSchema which was missing them. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(agent-adapters): update gemini settings approval mode assertion settings.json general.defaultApprovalMode requires "default" | "auto_edit" | "plan". "yolo" is not a valid enum value — it can only be enabled via CLI flag (--yolo or --approval-mode=yolo). See: https://geminicli.com/docs/reference/configuration/ Update the test expectation to reflect that the adapter maps "yolo" → "auto_edit" for the settings file while keeping the CLI flag as-is. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Ramesh Nethi <r.nethi@gogatewayai.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
- Fix kubeVersion constraint to allow GKE pre-release versions (>=1.33.0-0) - Add WebSocket appProtocol annotation to API service for proper Gateway routing - Support existing Gateway via configurable parentRefs in HTTPRoute - Add --platform flag to image build script for multi-architecture builds These changes enable deployment on GKE clusters with Gateway API and improve cross-platform image building for ARM/AMD64 architectures. Co-authored-by: Ramesh Nethi <r.nethi@gogatewayai.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
The two-pass drift correction used setHours() (local time) and only accounted for whole-hour drift. On systems with sub-hour UTC offsets (e.g. IST = UTC+5:30) this introduced a 30-minute error, causing off-peak transition times to be calculated incorrectly. Fix: use setTime() with a millisecond-precision drift that includes the minute component from getETComponents. Co-authored-by: Ramesh Nethi <r.nethi@gogatewayai.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
The K8s securityContext in k8s-workload-service.ts sets runAsUser=1001, but the base image was creating the agent user with UID 1000. This mismatch caused git to fail with permission errors because: - Pod runs as UID 1001 (no matching user in /etc/passwd) - No HOME directory set for UID 1001 - Git falls back to / for .gitconfig - Permission denied: /.gitconfig Fix: - Changed agent user from UID 1000 to UID 1001 - Removed ubuntu user deletion (no longer needed - agent naturally gets 1001) - Simplified Dockerfile by removing unnecessary steps This aligns with commit eeaa4ba which changed K8s to UID 1001. Co-authored-by: Ramesh Nethi <r.nethi@gogatewayai.com> Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
pnpm turbo test)pnpm turbo typecheck)Related
Closes #
Screenshots