Only virko can trigger deployments (PF-3369)#38
Draft
claude[bot] wants to merge 1 commit into
Draft
Conversation
Bump vendored lib-jsonnet to 358da535b48d02d139dee0974843d2e646b972fe and regenerate workflows. The deploymentTargets() helper now gates deploy jobs so they only run for deployment events created by gynzy-virko. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0194WzrNYXRJKhejZT9gdpdF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Stef Louwers · Slack thread
Before: the
deployjob inRelease.ymlran for anydeploymentevent targeting theproductionenvironment, regardless of who created it — including manually-created deployment events.After: the deploy job only runs when the deployment event was created by the
gynzy-virkobot. Manually-created deployment events are skipped. The generated gate now reads:"${{ (github.event.deployment.environment == 'production') && github.event.deployment.creator.login == 'gynzy-virko' }}"How:
.github/jsonnet/GIT_VERSION) from85284ade969df3f45c01eb0a9c513267c0a60b81to the merged lib commit358da535b48d02d139dee0974843d2e646b972fe, where the virko gate is centralized indeploymentTargets()..github.jsonnetalready callsdeployment.deploymentTargets(['production'])for its deploy job, so the gate flows in automatically — no hand-edits to clauses..github/workflows/*.ymlvia the repo's.github/jsonnet/pull-upstream-and-rebuild.sh.Note: bumping the vendored lib also pulls in other lib changes accumulated since this repo's previous pin (e.g. updates to
cache.jsonnet,pnpm.jsonnet,pulumi.jsonnet, and the correspondingCI.yml/Build Agent Images.ymlregeneration). This is expected and consistent with the same approach taken in backend-nest #3462 and frontend-ember #7655.Reference: PF-3369.
Generated by Claude Code