Add "Disable Gyroflow's stretch" to preset export dialog#1138
Open
globalprojectscorp wants to merge 1 commit intogyroflow:masterfrom
Open
Add "Disable Gyroflow's stretch" to preset export dialog#1138globalprojectscorp wants to merge 1 commit intogyroflow:masterfrom
globalprojectscorp wants to merge 1 commit intogyroflow:masterfrom
Conversation
Add a checkbox under the "Lens profile" section in the preset settings selector. When checked, writes `plugin_disable_stretch: true` to the exported .gyroflow preset file. This flag is read by the OFX/Adobe plugins (see gyroflow/gyroflow-plugins#51) to automatically enable "Disable Gyroflow's stretch" when loading the preset. Unchecked by default since it's only needed when the NLE handles anamorphic desqueeze (e.g. via Pixel Aspect Ratio in DaVinci Resolve).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a "Disable Gyroflow's stretch" checkbox to the preset export settings dialog, under the Lens profile section. When checked, writes
"plugin_disable_stretch": trueto the exported.gyroflowpreset file.Companion PR
gyroflow/gyroflow-plugins#51 — the plugin-side change that reads this flag and auto-enables "Disable Gyroflow's stretch" when loading a preset/lens profile containing it.
Motivation
When using anamorphic lenses in DaVinci Resolve (or any NLE that handles desqueeze via Pixel Aspect Ratio), users must manually check "Disable Gyroflow's stretch" on every clip in the OFX plugin. This setting couldn't be saved in presets because it's a plugin-level parameter with no representation in the gyroflow project format.
With both PRs merged, the workflow becomes:
Changes
src/ui/SettingsSelector.qml:plugin_disable_stretch: trueingetFilteredObject()since it's a plugin-specific flag not present in the gyroflow export data🤖 Generated with Claude Code