Remove obsolete 'to' keyword - no longer used in Roc#6
Open
rubywwwilde wants to merge 3 commits intoh2000:mainfrom
Open
Remove obsolete 'to' keyword - no longer used in Roc#6rubywwwilde wants to merge 3 commits intoh2000:mainfrom
rubywwwilde wants to merge 3 commits intoh2000:mainfrom
Conversation
rubywwwilde
commented
Aug 16, 2025
Author
rubywwwilde
left a comment
rubywwwilde
left a comment
There was a problem hiding this comment.
Omg, this has a bug, sorry
rubywwwilde
commented
Aug 16, 2025
languages/roc/highlights.scm
Outdated
| "module" | ||
| "package" | ||
| "import" | ||
| "provides |
This was my first time working with this domain. That means I could have made some really dumb mistakes. My current approach was to copy all the files from tree-sitter: `cp queries/*.scm ~/Projects/zed-roc/languages/roc/`. Additionally I've moved (identifier) @string to the top, cause it was ruining everything at the bottom. Then I added this line to color the declarations, as it is done in nvim plugin: (value_declaration (decl_left (identifier_pattern (identifier) @variable.parameter)))
Author
|
omg, I spent the whole hour in hyperfocus trying to understand what this is all about. it seems to be working now and it matches nvim's implementation pretty closely 
|
Owner
|
@rubywwwilde could you please retest with newest version from main? |
Author
|
Yes, it does work. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'to' keyword is no longer used in Roc and was sometimes causing incorrect highlighting of identifiers containing "to" (like "todos", "into", etc).
According to the Roc community, the header style
app "test" provides [main] to "./platform"is deprecated and 'to' is no longer a keyword.This PR removes the
(to)node from the syntax highlighting rules to fix the incorrect highlighting behavior.Fixes: Variables like "todos" incorrectly highlighting "to" portion