HFP-4350 Add missing custom CSS props for theming#181
Open
otacke wants to merge 1 commit into
Open
Conversation
otacke
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged in, will set keys and values for theming related custom CSS properties.
For the four predefined sets, the values match what the theme picker sets on H5P.com and for
corethe value needs to be emptied to use the values set by H5P core.Please note that H5P core does currently not set a value for
--h5p-theme-contrast-cta-dark, cmp. https://h5ptechnology.atlassian.net/browse/HFP-4349 for details and h5p/h5p-php-library#297 for a fix.