feat(admin): implement AdminLayout component with strict mode and stories#473
Merged
Merged
Conversation
…nd full a11y support - Implement AdminLayout component with Pioneer/Strict mode standards - Add zero-default props requirement (all behavioral props required) - Integrate Spinner component instead of raw HTML loading indicator - Add required accessibility props: ariaLabel, loadingLabel, sidebarAriaLabel - Include mobile drawer support with Sidebar and Drawer components - Add defensive checks for snippet rendering - Create comprehensive Storybook stories (13 stories including Playground) - Document structural HTML usage per AGENTS.md guidelines - Export component from src/lib/index.ts BREAKING CHANGE: All behavioral props are now required (no defaults)
- Separate desktop and mobile layouts to prevent drawer panel from showing on lg+ screens - Desktop: Direct sidebar + main layout without Drawer wrapper - Mobile: Drawer-based sidebar with proper content isolation - Fixes visual bug where sidebar appeared twice on desktop viewports
- Remove default args from Storybook defineMeta configuration - Fixes double sidebar rendering issue in all stories - Snippet-based components should not use args for auto-render
github-project-automation
Bot
moved this from 📥 Inbox / Ideas
to Done
in hexaTune Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📄 Summary
This PR introduces the
AdminLayoutcomponent for theadmin/layoutmodule.The component is implemented in Pioneer Strict Mode, serving as a reference layout that enforces the project's highest architectural standards: explicit configuration, composition-first design, and full i18n/a11y compliance.
ariaLabel,loadingLabel,sidebarAriaLabel) is passed explicitly for i18n.Sidebar,Drawer, andSpinner.$props,$derived,$derived.by, and$bindable.🧩 Affected Module(s)
✅ Checklist
feat/admin-layout-implementationpnpm format)pnpm check) and resolved warningsCloses #219🔗 Related Issues
Closes #219