feat(utility): add public page layout component#487
Merged
Conversation
…ive grid fix - Add PublicPageLayout component for public-facing pages - Implement comprehensive layout with NavBar, Container, and FooterBar integration - Add loading state with Loader component - Support for fixed/sticky navbar with dynamic padding - Add Storybook stories with multiple layout examples (Hero, Features, Pricing, Simple) - Fix Grid component responsive columns logic to prevent CSS conflicts - Export PublicPageLayout and related types in lib/index.ts Technical improvements: - Fixed Grid component to only apply base columns when responsiveColumns is not provided - Added whitespace-nowrap to feature headings for single-line display - Implemented responsive grid (xs: 1, md: 2, lg: 3 columns) for better mobile/desktop UX - Removed raw HTML div, using Container className prop instead Resolves #174 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📄 Summary
This PR implements the
PublicPageLayoutcomponent for public-facing pages (landing pages, marketing pages, documentation pages). The component provides a complete layout structure with configurable navbar, main content area with container support, and footer.Additionally, this PR fixes a critical bug in the
Gridcomponent where base columns and responsive columns were being applied simultaneously, causing CSS conflicts and unpredictable layout behavior.Key Features:
🧩 Affected Module(s)
Mark the modules impacted by this PR:
✅ Checklist
Before submitting, make sure you've completed the following:
🔗 Related Issues
Closes #174