feat(sidequest): add roasted apples sidequest#2086
Open
Eobam wants to merge 35 commits intohackclub:mainfrom
Open
feat(sidequest): add roasted apples sidequest#2086Eobam wants to merge 35 commits intohackclub:mainfrom
Eobam wants to merge 35 commits intohackclub:mainfrom
Conversation
Member
|
Hello, please make sure your PR title follows https://www.conventionalcommits.org/en/v1.0.0/ Eg: |
Eobam
changed the title
Eobam
changed the title
Eobam
changed the title
anirudh12032008
suggested changes
Apr 10, 2026
|
Approve it!! |
Contributor
|
ps: you might have to rebase this or merge |
|
pls approve :pls: |
cskartikey
requested changes
Apr 14, 2026
Member
|
cc: @transcental do we want to gate apple dev license behind this sidequest? |
Author
|
we don't have to, but it currently isn't even in the shop |
Member
|
I'm fine w/ the licence being gated, however no shop item additions/removals/changes should be hardcoded. |
Contributor
|
@Eobam You did not resolve merge conflict, you left the markers! |
Author
|
bleh, you are right |
|
when? |
|
whennn |
Contributor
|
Leaving this thread here where I pointed out a bunch of issues if anyone wants to follow along: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Roasted Apples sidequest. It adds the description, as well as submission flow! image of preview coming here soon