Skip to content

HCK-13821: Alter script for datetime type properties #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
Dec 4, 2025
Merged

HCK-13821: Alter script for datetime type properties #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 31 additions & 16 deletions forward_engineering/alterScript/alterScriptHelpers/columnHelpers/alterTypeHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,26 +30,43 @@ const alterColumnType = (tableName, columnName, type, columnDefinition) => {
/**
* @return {boolean}
* */
const hasLengthChanged = (collection, oldFieldName, currentJsonSchema) => {
const haveTypeRelatedPropertiesChanged = (collection, oldFieldName, currentJsonSchema) => {
const oldProperty = collection.role.properties[oldFieldName];

const previousLength = oldProperty?.length;
const oldLength = oldProperty?.length;
const newLength = currentJsonSchema?.length;
return previousLength !== newLength;
};

/**
* @return {boolean}
* */
const hasPrecisionOrScaleChanged = (collection, oldFieldName, currentJsonSchema) => {
const oldProperty = collection.role.properties[oldFieldName];

const previousPrecision = oldProperty?.precision;
const oldPrecision = oldProperty?.precision;
const newPrecision = currentJsonSchema?.precision;
const previousScale = oldProperty?.scale;

const oldScale = oldProperty?.scale;
const newScale = currentJsonSchema?.scale;

return previousPrecision !== newPrecision || previousScale !== newScale;
const oldFractSecPrecision = oldProperty?.fractSecPrecision;
const newFractSecPrecision = currentJsonSchema?.fractSecPrecision;

const oldWithTimeZone = oldProperty?.withTimeZone;
const newWithTimeZone = currentJsonSchema?.withTimeZone;

const oldLocalTimeZone = oldProperty?.localTimeZone;
const newLocalTimeZone = currentJsonSchema?.localTimeZone;

const oldYearPrecision = oldProperty?.yearPrecision;
const newYearPrecision = currentJsonSchema?.yearPrecision;

const oldDayPrecision = oldProperty?.dayPrecision;
const newDayPrecision = currentJsonSchema?.dayPrecision;

return (
oldLength !== newLength ||
oldPrecision !== newPrecision ||
oldScale !== newScale ||
oldFractSecPrecision !== newFractSecPrecision ||
oldWithTimeZone !== newWithTimeZone ||
oldLocalTimeZone !== newLocalTimeZone ||
oldYearPrecision !== newYearPrecision ||
oldDayPrecision !== newDayPrecision
);
};

/**
Expand All @@ -68,9 +85,7 @@ const getUpdateTypesScriptDtos = (ddlProvider, scriptFormat) => collection => {
const hasTypeChanged = checkFieldPropertiesChanged(jsonSchema.compMod, ['type', 'mode']);
if (!hasTypeChanged) {
const oldName = jsonSchema.compMod.oldField.name;
const isNewLength = hasLengthChanged(collection, oldName, jsonSchema);
const isNewPrecisionOrScale = hasPrecisionOrScaleChanged(collection, oldName, jsonSchema);
return isNewLength || isNewPrecisionOrScale;
return haveTypeRelatedPropertiesChanged(collection, oldName, jsonSchema);
}
return hasTypeChanged;
})
Expand Down