Skip to content

HCK-12336: remove redundant ASC keyword in PK and UK constraints FE script #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Vitalii4as merged 2 commits into from
Aug 12, 2025
Merged

HCK-12336: remove redundant ASC keyword in PK and UK constraints FE script #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34e62f6
HCK-12336: remove redundant ASC keyword
Aug 12, 2025
02702bd
Merge branch 'develop' into HCK-12336-remove-asc-from-pk-and-uk-synap…
NazarKovtun1 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion forward_engineering/helpers/constraintsHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ module.exports = app => {

const createKeyConstraint = (templates, terminator, isParentActivated) => keyData => {
const partition = keyData.partition ? ` ON [${keyData.partition}]` : '';
const columnMapToString = ({ name, order }) => `[${name}] ${order}`.trim();
const columnMapToString = ({ name }) => `[${name}]`.trim();

const isAllColumnsDeactivated = checkAllKeysDeactivated(keyData.columns);

Expand Down
13 changes: 0 additions & 13 deletions forward_engineering/helpers/keyHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,24 +65,13 @@ module.exports = app => {
}
};

const getOrder = order => {
if (_.toLower(order) === 'asc') {
return 'ASC';
} else if (_.toLower(order) === 'desc') {
return 'DESC';
} else {
return '';
}
};

const hydrateUniqueOptions = (options, columnName, isActivated) =>
clean({
keyType: 'UNIQUE',
name: options['constraintName'],
columns: [
{
name: columnName,
order: getOrder(options['order']),
isActivated: isActivated,
},
],
Expand All @@ -108,7 +97,6 @@ module.exports = app => {
columns: [
{
name: columnName,
order: getOrder(options['order']),
isActivated: isActivated,
},
],
Expand Down Expand Up @@ -143,7 +131,6 @@ module.exports = app => {
return keys.map(key => {
return {
name: findName(key.keyId, jsonSchema.properties),
order: key.type === 'descending' ? 'DESC' : 'ASC',
isActivated: checkIfActivated(key.keyId, jsonSchema.properties),
};
});
Expand Down
4 changes: 1 addition & 3 deletions reverse_engineering/reverseEngineeringService/helpers/defineFieldsCompositeKeyConstraints.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const PRIMARY_KEY = 'PRIMARY KEY';
const reverseCompositeKeys = keyConstraintsInfo => {
const keyCompositionStatuses = getKeyConstraintsCompositionStatuses(keyConstraintsInfo);
return keyConstraintsInfo.reduce((reversedKeys, keyConstraintInfo) => {
const { columnName, constraintName, constraintType, isDescending } = keyConstraintInfo;
const { columnName, constraintName, constraintType } = keyConstraintInfo;
const compositionStatus = keyCompositionStatuses[constraintName];
const existingReversedKey = reversedKeys[constraintName];
const keyType = constraintType === PRIMARY_KEY ? 'compositePrimaryKey' : 'compositeUniqueKey';
Expand All @@ -24,7 +24,6 @@ const reverseCompositeKeys = keyConstraintsInfo => {
[keyType]: [
{
name: columnName,
type: isDescending ? 'descending' : 'ascending',
},
],
},
Expand All @@ -44,7 +43,6 @@ const reverseCompositeKeys = keyConstraintsInfo => {
...existingReversedKey[keyType],
{
name: columnName,
type: isDescending ? 'descending' : 'ascending',
},
],
},
Expand Down