Skip to content

HCK-13038: adjust Azure MFA auth for RE #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taras-dubyk merged 3 commits into from
Oct 14, 2025
Merged

HCK-13038: adjust Azure MFA auth for RE #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80f5710
fix db name parsing
taras-dubyk Oct 13, 2025
4092d11
adjust connection parameters for Azure Entra ID
taras-dubyk Oct 13, 2025
54dd1ac
remove unused msal-node package
taras-dubyk Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"icon_url": "logo.jpg",
"disabled": false,
"dependencies": {
"@azure/msal-node": "3.8.0",
"@hackolade/fetch": "1.3.0",
"base64url": "3.0.1",
"crypto": "1.0.1",
Expand Down Expand Up @@ -80,4 +79,4 @@
"prettier": "3.2.5",
"simple-git-hooks": "2.11.1"
}
}
}
15 changes: 3 additions & 12 deletions reverse_engineering/connection_settings_modal/connectionSettingsModalConfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
{
"inputLabel": "Host",
"inputKeyword": "host",
"inputPlaceholder": "Host",
"description": "Specify Azure Synapse server name",
"inputType": "text",
"dependency": {
Expand Down Expand Up @@ -117,7 +118,7 @@
},
{
"value": "Azure Active Directory (MFA)",
"label": "Azure Active Directory (MFA)"
"label": "Azure Entra ID (MFA)"
}
]
},
Expand Down Expand Up @@ -155,17 +156,7 @@
"inputTooltip": "Specify the Tenant ID from the Overview screen of your Azure AD tenant",
"dependency": {
"key": "authMethod",
"value": ["Azure Active Directory (Username / Password)", "Azure Active Directory (MFA)"]
}
},
{
"inputLabel": "User Name",
"inputKeyword": "loginHint",
"inputType": "text",
"inputPlaceholder": "User Name",
"dependency": {
"key": "authMethod",
"value": ["Azure Active Directory (MFA)"]
"value": ["Azure Active Directory (Username / Password)"]
}
}
]
Expand Down
1 change: 0 additions & 1 deletion reverse_engineering/databaseService/helpers/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const { hckFetch } = require('@hackolade/fetch');
const sql = require('mssql');
const msal = require('@azure/msal-node');
const { logAuthTokenInfo, logConnectionHostAndUsername } = require('../../helpers/logInfo');
const { prepareError } = require('./errorService');
const { parseResponse } = require('../../helpers/parseResponse');
Expand Down
2 changes: 1 addition & 1 deletion reverse_engineering/helpers/parseConnectionString.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const parseSqlServerUrl = ({ url = '' }) => {
return {
host,
port: port ? Number(port) : null,
databaseName: params.databaseName,
databaseName: params.databaseName || params.database,
userName: params.user,
userPassword: params.password,
};
Expand Down