Skip to content

HCK-13868: HiveQL script generation options#79

Merged
chulanovskyi-bs merged 16 commits intodevelopfrom
HCK-13868
Dec 18, 2025
Merged

HCK-13868: HiveQL script generation options#79
chulanovskyi-bs merged 16 commits intodevelopfrom
HCK-13868

Conversation

@AlikRakhmonov
Copy link
Copy Markdown
Contributor

@AlikRakhmonov AlikRakhmonov commented Dec 17, 2025 •
edited
Loading

Sub-taskHCK-13868 Portable to Glue (HQL script in Glue)?

Technical details

  1. Update HiveQL script generation.
  2. Add HiveQL script generation options.
  3. Delete the downloaded sql-formatter lib and install using npm.
  4. Add disableScriptGenerationOptions flag to script format options.
  5. Now getTypeByProperty is getTypeByProperty: (definitions) => (type) => string, so glueColumnHelper is updated accordingly.
  6. Comments are managed differently than in the Hive plugin. See https://hackolade.atlassian.net/browse/HCK-14037

@AlikRakhmonov AlikRakhmonov self-assigned this Dec 17, 2025
@AlikRakhmonov AlikRakhmonov changed the title Hck 13868 HCK-13868: HiveQL script generation options Dec 17, 2025
@AlikRakhmonov AlikRakhmonov marked this pull request as ready for review December 17, 2025 15:25
chulanovskyi-bs
chulanovskyi-bs reviewed Dec 18, 2025
View reviewed changes
Comment thread forward_engineering/generateScript.js Outdated
@chulanovskyi-bs chulanovskyi-bs enabled auto-merge (squash) December 18, 2025 09:05
@AlikRakhmonov AlikRakhmonov enabled auto-merge (squash) December 18, 2025 09:51
@AlikRakhmonov AlikRakhmonov enabled auto-merge (squash) December 18, 2025 10:40
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 18, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.0% Duplication on New Code

See analysis details on SonarQube Cloud

@chulanovskyi-bs chulanovskyi-bs merged commit e7de79e into develop Dec 18, 2025
1 check passed
@chulanovskyi-bs chulanovskyi-bs deleted the HCK-13868 branch December 18, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chulanovskyi-bs chulanovskyi-bs chulanovskyi-bs approved these changes

Assignees

@AlikRakhmonov AlikRakhmonov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AlikRakhmonov @chulanovskyi-bs