Skip to content

HCK-14049: alter has DB name already #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chulanovskyi-bs merged 1 commit into from
Dec 18, 2025
Merged

HCK-14049: alter has DB name already #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 2 additions & 32 deletions forward_engineering/hiveHelpers/helpers/alterScriptHelpers/alterForeignKeyHelper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,28 +126,6 @@ const getAlterForeignKeyScripts = ({ schema, provider, currentSchemaName, ignore
.flatMap(getScript);
};

const getRelationshipsScriptsWithUseSchema = (relationships, processRelationships, getScript) => {
return processRelationships(relationships, relationship => {
const script = getScript(provider)(relationship);

if (!script) {
return [];
}

const schemaName = prepareName(relationship.role.compMod.child.bucket?.name || '');

if (currentSchemaName === schemaName) {
return [script];
}

currentSchemaName = schemaName;

const useSchemaScript = provider.assignTemplates(templates.useSchema, { schemaName });

return [useSchemaScript, script];
});
};

const deletedRelationships = getItems(schema, 'relationships', 'deleted').filter(
relationship => relationship.role?.compMod?.deleted && !ignoreRelationshipIDs.includes(relationship?.role?.id),
);
Expand All @@ -157,16 +135,8 @@ const getAlterForeignKeyScripts = ({ schema, provider, currentSchemaName, ignore
const modifiedRelationships = getItems(schema, 'relationships', 'modified');

const deleteFkScripts = getDeleteForeignKeyScripts(provider)(deletedRelationships);
const addFkScripts = getRelationshipsScriptsWithUseSchema(
addedRelationships,
generateAddFkScripts,
getAddForeignKeyScript,
);
const modifiedFkScripts = getRelationshipsScriptsWithUseSchema(
modifiedRelationships,
generateModifyFkScripts,
getModifyForeignKeyScript,
);
const addFkScripts = generateAddFkScripts(addedRelationships, getAddForeignKeyScript(provider));
const modifiedFkScripts = generateModifyFkScripts(modifiedRelationships, getModifyForeignKeyScript(provider));
return { deleteFkScripts, addFkScripts, modifiedFkScripts };
};

Expand Down
2 changes: 0 additions & 2 deletions forward_engineering/hiveHelpers/helpers/alterScriptHelpers/config/templates.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,4 @@ module.exports = {

addFkConstraint:
'ALTER TABLE ${childTableName} ADD CONSTRAINT ${constraintName} FOREIGN KEY (${childColumns}) REFERENCES ${parentTableName}(${parentColumns})${disableNoValidate};',

useSchema: 'USE ${schemaName};',
};