done#10
Open
azizomarck wants to merge 1 commit into
Open
Conversation
epq
reviewed
Sep 13, 2019
| console.log((3 === 3) ? "yes" : "no"); | ||
|
|
||
| //6 | ||
| function vehicle(color,code,age){ |
Collaborator
There was a problem hiding this comment.
You haven't used your age parameter here. What if I wanted to print out a new vehicle?
|
|
||
| function printFavoriteBooks(){ | ||
| for(let i = 0; i<favoriteBooks.length; i++){ | ||
| console.log(`Your ${favoriteBooks.length } favorite books are : ${i+1}. ${favoriteBooks[i]}`) |
Collaborator
There was a problem hiding this comment.
It's not really an issue, but I would just print out Your ${favoriteBooks.length } favorite books are once at the beginning instead of inside the loop because this message is more like a title instead of something that should be repeated for each line.
| }; | ||
|
|
||
| //3 | ||
| function printObj(obj){ |
Collaborator
There was a problem hiding this comment.
Your function is well-written, but the question also asks you to create a sample object.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.