rock-paper-scissors homework submission#5
Open
hamzakoc wants to merge 2 commits into
Open
Conversation
Collaborator
|
@farnous Please leave some feedback for Hamza! |
farnous
suggested changes
Sep 13, 2019
|
|
||
|
|
||
|
|
||
| function game (){ |
There was a problem hiding this comment.
the function work perfectly
but it does not show the final result of the 5 rounds ( I mean who won the most rounds )
you can save the rounds in an array and at the end of the game you can check who win.
and also you may not count the round if the result is ( tie ) because no one win
|
|
||
| function playRound(playerSelection,computerSelection){ | ||
|
|
||
| if( playerSelection !== "rock" && playerSelection !== "paper" && playerSelection !== "scissors" ){ |
There was a problem hiding this comment.
Hello Hamza
I think if you convert the playerSelection to lower case at the beginning of the function it will let the player to insert the choice as he/she want , for example : rock, Rock, ROCK.
Suggested change
| if( playerSelection !== "rock" && playerSelection !== "paper" && playerSelection !== "scissors" ){ | |
| playerSelection = playerSelection..toLowerCase(); | |
| if( playerSelection !== "rock" && playerSelection !== "paper" && playerSelection !== "scissors" ){ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.