Skip to content

feat: add missing file extensions to CODE_EXTENSIONS#285

Merged
haiphucnguyen merged 1 commit intohaiphucnguyen:mainfrom
miguel-baptista07:fix/add-code-extensions-276
Mar 30, 2026
Merged

feat: add missing file extensions to CODE_EXTENSIONS#285
haiphucnguyen merged 1 commit intohaiphucnguyen:mainfrom
miguel-baptista07:fix/add-code-extensions-276

Conversation

@miguel-baptista07
Copy link
Copy Markdown
Contributor

@miguel-baptista07 miguel-baptista07 commented Mar 23, 2026

Fixes #276

Changes

  • Added config/build files: toml, lock
  • Added Terraform: tf, tfvars
  • Added data formats: jsonc, json5, graphql, gql, proto
  • Added WebAssembly: wat
  • Added emerging languages: zig, v
  • Added Go modules: mod, sum
  • Added Nix & Dhall: nix, dhall
  • Added support for extensionless files (Dockerfile, Makefile, etc.)
  • Updated FileContentExtractor to handle extensionless files
  • Added comprehensive test suite (9 tests, all passing)

@cla-assistant
Copy link
Copy Markdown

cla-assistant Bot commented Mar 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

haiphucnguyen
haiphucnguyen reviewed Mar 23, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@haiphucnguyen haiphucnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @miguel-baptista07 for your contribution. I leaved some comments

Comment thread shared/src/main/kotlin/io/askimo/core/chat/util/FileTypeSupport.kt Outdated
Comment thread shared/src/main/kotlin/io/askimo/core/chat/util/FileTypeSupport.kt Outdated
Comment thread shared/src/main/kotlin/io/askimo/core/chat/util/FileContentExtractor.kt
Comment thread shared/src/main/kotlin/io/askimo/core/chat/util/FileContentExtractor.kt Outdated
Comment thread shared/src/main/kotlin/io/askimo/core/chat/util/FileTypeSupport.kt Outdated
@miguel-baptista07 miguel-baptista07 force-pushed the fix/add-code-extensions-276 branch from 3e2c62a to 101b33d Compare March 24, 2026 16:03
@miguel-baptista07
Copy link
Copy Markdown
Contributor Author

miguel-baptista07 commented Mar 24, 2026 •
edited
Loading

All requested changes have been applied and conversations resolved.

Let me know if anything else is needed

haiphucnguyen
haiphucnguyen reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Owner

@haiphucnguyen haiphucnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments. Thanks for completing the user error message ticket too! Overall they looks good.

Please check the file encoding, it seems you are using the Ascii encoding which does not do well with UTF-8 encoding characters.

Also could you format the codes by following this instruction http://askimo.chat/docs/development/getting-started/#code-formatting

Comment thread desktop-shared/src/main/resources/i18n/messages_zh_CN.properties Outdated
Comment thread desktop-shared/src/main/resources/i18n/messages_de.properties Outdated
@haiphucnguyen
Copy link
Copy Markdown
Owner

haiphucnguyen commented Mar 27, 2026

Hi @miguel-baptista07 , I would like to follow up this PR since we fix the encoding issues of properties file then we are good to merge

@miguel-baptista07 miguel-baptista07 force-pushed the fix/add-code-extensions-276 branch from 101b33d to 9aa0380 Compare March 29, 2026 13:26
@miguel-baptista07
Copy link
Copy Markdown
Contributor Author

miguel-baptista07 commented Mar 29, 2026

Hi @haiphucnguyen, encoding has been fixed to UTF-8 for all localization files. Ready for merge!

@Miguelkn
feat: add missing code/config file extensions to CODE_EXTENSIONS
9ab71dc 
- Added config/build files: toml, lock
- Added Terraform: tf, tfvars
- Added data formats: jsonc, json5, graphql, gql, proto
- Added WebAssembly: wat
- Added Emerging languages: zig, v
- Added Go modules: mod, sum
- Added Nix & Dhall: nix, dhall
- Added CONFIG_EXTENSIONS for extensionless files (dockerfile, makefile, etc.)
- Updated FileContentExtractor logic as suggested by maintainer
- Added test suite covering all new extensions

Fixes haiphucnguyen#276

Signed-off-by: Miguel <miguelkevlin23@gmail.com>
@miguel-baptista07 miguel-baptista07 force-pushed the fix/add-code-extensions-276 branch from 9aa0380 to 9ab71dc Compare March 29, 2026 13:36
@haiphucnguyen
Copy link
Copy Markdown
Owner

haiphucnguyen commented Mar 30, 2026

Thank you @miguel-baptista07 for this PR!

@haiphucnguyen haiphucnguyen merged commit 8732f27 into haiphucnguyen:main Mar 30, 2026
18 of 19 checks passed
@haiphucnguyen haiphucnguyen mentioned this pull request Mar 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haiphucnguyen haiphucnguyen haiphucnguyen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add more code/config file extensions to CODE_EXTENSIONS

3 participants

@miguel-baptista07 @haiphucnguyen @Miguelkn