Skip to content

Fix "Invalid event" error when server sent heartbeats #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tribela wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "Invalid event" error when server sent heartbeats #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d50b555
Fix "Invalid event" error when server sent heartbeats
tribela Mar 1, 2026
3962d2e
Add test for empty event after heartbeat
tribela Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions mastodon/streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,9 @@ def _parse_line(self, line, event):
return event

def _dispatch(self, event):
if not event:
return

try:
name = event['event']
data = event['data']
Expand Down
8 changes: 8 additions & 0 deletions tests/test_streaming.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,14 @@ def test_heartbeat():
assert listener.heartbeats == 2



def test_heartbeat_empty_line():
"""Empty event after heartbeat should not raise an error."""
listener = Listener()
# Heartbeat followed by empty line triggers _dispatch with empty event
listener.handle_stream_([':thump', ''])
assert listener.heartbeats == 1

def test_status():
listener = Listener()
listener.handle_stream_([
Expand Down