Skip to content

feat: migrate to ns7#4

Open
rigor789 wants to merge 1 commit into
halfnelson:masterfrom
rigor789:feat/ns7
Open

feat: migrate to ns7#4
rigor789 wants to merge 1 commit into
halfnelson:masterfrom
rigor789:feat/ns7

Conversation

@rigor789

@rigor789 rigor789 commented Sep 5, 2020

Copy link
Copy Markdown

No description provided.

@halfnelson halfnelson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from those changes (to get latest versions and to help with hmr) looks awesome

Comment thread package.json
"nativescript-theme-core": "^2.0.23",
"svelte-native": "^0.6.1",
"tns-core-modules": "~6.1.2"
"svelte-native": "0.9.1",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to release a fix, so this should probably be ~0.9.2

Comment thread package.json
"typescript": "3.6.2"
"@nativescript/android": "7.0.0",
"svelte": "3.24.1",
"svelte-loader-hot": "0.3.0",

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be "~0.3.0" which should pick up 0.3.1

Comment thread webpack.config.js
loader: 'svelte-loader-hot',
options: {
preprocess: svelteNativePreprocessor(),
hotReload: true,

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to use the following options to keep this happy

options: {
      dev: env.production ? false : true,
      preprocess: svelteNativePreprocessor(),
      hotReload: env.production ? false : true,
      hotOptions: {
           injectCss: false,
           native: true
      }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants