refactor(docker): respect image settings, use vals, customizable registry protocol#128
Open
refactor(docker): respect image settings, use vals, customizable registry protocol#128
Conversation
yajo
force-pushed
the
fix-images-push
branch
5 times, most recently
from
56e5b83 to
aa9b5d6
Compare
…stry protocol
This is a bunch of fixes together to cover a single use case, the one expressed in the included test: multiple images pushed to different destinations with a single script.
Image registry, name and tag can use `vals`, just like the rest of Kubenix, to expand dynamic or secret references on run time.
BREAKING CHANGE: `docker.copyScript` now puts a binary inside `$out/bin/kubenix-push-images`. The benefit is that now you can just `nix run .#kubenix.config.docker.copyScript`, which is more ergonomic.
BREAKING CHANGE: Registry definitions, which were never a URL, are no longer set in a `url` option. Instead of using `docker.registry.url` and `docker.images.*.registry` options are now consolidated into `[docker.registry|docker.images.*.registry].registry.{protocol,host}`, which behave as you'd expect.
BREAKING CHANGE: `docker.copyScript` push images to `docker.images.*.uri` instead of a handmade combination of the `imageName` and `imageTag` passthru attributes of the `docker.images.*.image` derivation.
@moduon MT-1075
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor(docker): respect image settings, use vals, customizable registry protocol
This is a bunch of fixes together to cover a single use case, the one expressed in the included test: multiple images pushed to different destinations with a single script.
Image registry, name and tag can use
vals, just like the rest of Kubenix, to expand dynamic or secret references on run time.BREAKING CHANGE:
docker.copyScriptnow puts a binary inside$out/bin/kubenix-push-images. The benefit is that now you can justnix run .#kubenix.config.docker.copyScript, which is more ergonomic.BREAKING CHANGE: Registry definitions, which were never a URL, are no longer set in a
urloption. Instead of usingdocker.registry.urlanddocker.images.*.registryoptions are now consolidated into[docker.registry|docker.images.*.registry].registry.{protocol,host}, which behave as you'd expect.BREAKING CHANGE:
docker.copyScriptpush images todocker.images.*.uriinstead of a handmade combination of theimageNameandimageTagpassthru attributes of thedocker.images.*.imagederivation.@moduon MT-1075