Draft
Conversation
Co-authored-by: agent <agent@hanbings.io>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
, let ...syntax forif/whileconditionsThis PR introduces a more natural
letchain syntax forifandwhileconditions, allowing, let ...as a separator.Why this change?
This change addresses the desire for a more intuitive way to chain
letpatterns in conditional expressions, aligning with discussions around RFCs forif-letchains.How it works:
The parser now recognizes top-level
, let ...withinif/whileconditions and transforms it into an equivalent&& let ...in the Abstract Syntax Tree (AST). This approach ensures:&& let ...chains.let-chainvalidation and lowering logic, minimizing new parsing complexity.if/whilecondition parsing, avoiding ambiguity with tuple expressions.Related: