Draft
Conversation
This adds sugar for `if let` expressions, allowing `if opt matches Some(x)`. Co-authored-by: agent <agent@hanbings.io>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces
if <expr> matches <pat>as syntactic sugar forif let <pat> = <expr>.This change provides a more fluent and natural syntax for conditional pattern matching, offering an alternative to
if let.The new syntax
if <expr> matches <pat>is parsed into the sameExprKind::Let(<pat>, <expr>, ..)AST node asif let <pat> = <expr>, ensuring identical semantics and no breaking changes. This special parsing formatchesonly occurs withinif/whileconditions (whenRestrictions::ALLOW_LETis active) to avoid conflicts withmatchesused as a regular identifier.A UI test has been added to cover the new syntax and confirm that
matchesas an identifier remains valid in other contexts.