Skip to content

Display TXT records with mono space style#1

Open
Falci wants to merge 3 commits into
handshake-labs:masterfrom
sinpapeles:txt1
Open

Display TXT records with mono space style#1
Falci wants to merge 3 commits into
handshake-labs:masterfrom
sinpapeles:txt1

Conversation

@Falci
Copy link
Copy Markdown

@Falci Falci commented Nov 23, 2021

image

@randomlogin randomlogin requested a review from Ximik November 24, 2021 01:24
@randomlogin
Copy link
Copy Markdown
Member

randomlogin commented Nov 24, 2021

Not quite sure why, but it renders the other way for me, with margin property being not in force.
image
Browser: chrome Version 92.0.4515.159, but same for firefox.

Comment thread src/components/Name/RecordItem.tsx Outdated
break;
case "TXT":
resource = <div>TXT: {record.txt}</div>;
resource = <div>TXT: <pre className="txt">{record.txt}</pre></div>;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you hate me if i think this formatting should be applied to all record types?

@Falci
Copy link
Copy Markdown
Author

Falci commented Dec 10, 2021

@randomlogin tested locally. Now it looks like the first screenshot

@Falci
Copy link
Copy Markdown
Author

Falci commented Dec 10, 2021

I didn't realised before, but this project uses styleName instead of className.
The css selectors in the imported file will be renamed (scoped)

@pinheadmz
Copy link
Copy Markdown

I would really like to see this deployed ;-)

By the way, niami does one extra thing with TXT records, which is a regex replacement to remove "escape" backslashes. You can compare with https://www.niami.io/domain/xviii_the_moon what I suggested to Stephan is these two regex: sed 's/\\"/\"/g' sed 's/\\\\/\\/g'

with white-space: pre; font-family: monospace
https://hnsnetwork.com/names/xviii_the_moon
Screen Shot 2022-02-28 at 9 45 05 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants