Merged
Conversation
pinheadmz
reviewed
May 1, 2020
| <span id="cb1-4"><a href="#cb1-4"></a> <span class="cf">await</span> node<span class="op">.</span><span class="fu">ensure</span>()<span class="op">;</span></span> | ||
| <span id="cb1-5"><a href="#cb1-5"></a> <span class="cf">await</span> node<span class="op">.</span><span class="fu">open</span>()<span class="op">;</span></span> | ||
| <span id="cb1-6"><a href="#cb1-6"></a> <span class="cf">await</span> node<span class="op">.</span><span class="fu">connect</span>()<span class="op">;</span></span> | ||
| <span id="cb1-7"><a href="#cb1-7"></a> node<span class="op">.</span><span class="fu">startSync</span>()<span class="op">;</span></span> |
Member
There was a problem hiding this comment.
hmm... why did events.html get re-rendered?
Collaborator
Author
There was a problem hiding this comment.
I didn't change anything in the events file so I assumed that it was due to an updated dependency. It didn't look like anything broke because of it but I can remove these changes from the commits.
Member
There was a problem hiding this comment.
I think its fine, the render looked good to me locally.
pinheadmz
approved these changes
May 1, 2020
Member
pinheadmz
left a comment
pinheadmz
left a comment
There was a problem hiding this comment.
tested, looks good. Good to go once PR to hsd is merged. Would also be nice to wait until hs-client is updated, then add the missing methods for CLI and JS, but also fine with doing that in another update.
Collaborator
Author
Was planning on going this route |
boymanjor
approved these changes
May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Node HTTP endpoint
GET /header/hashOrHeightto the docs.PR here:
handshake-org/hsd#210