wallet: update unconfirmed locked balance first during rescan#387
Merged
chjj merged 1 commit intohandshake-org:masterfrom Mar 19, 2020
Merged
wallet: update unconfirmed locked balance first during rescan#387chjj merged 1 commit intohandshake-org:masterfrom
chjj merged 1 commit intohandshake-org:masterfrom
Conversation
This was referenced Mar 10, 2020
nijynot
reviewed
Mar 13, 2020
boymanjor
previously approved these changes
Mar 19, 2020
Contributor
boymanjor
left a comment
boymanjor
left a comment
There was a problem hiding this comment.
LGTM with a couple of nits on comments.
Member
Author
|
@boymanjor thanks bruh. Updated those comments and pushed. |
Codecov Report
@@ Coverage Diff @@
## master #387 +/- ##
==========================================
+ Coverage 60.37% 60.42% +0.05%
==========================================
Files 129 129
Lines 34671 34673 +2
Branches 5859 5860 +1
==========================================
+ Hits 20931 20952 +21
+ Misses 13740 13721 -19
Continue to review full report at Codecov.
|
boymanjor
dismissed
their stale review
I'd like to investigate if we should solve this issue further up the call stack.
boymanjor
approved these changes
Mar 19, 2020
Contributor
boymanjor
left a comment
boymanjor
left a comment
There was a problem hiding this comment.
Ok, I think this is the right spot. Thanks for the clarification @pinheadmz!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #381
Replaces #385
Explanation here: #381 (comment)
The test runs through the REVEAL of an auction two ways: First, by sending and then confirming each covenant. Second, by JUST confirming each covenant without first "sending". The difference from perspective of the txdb is that if a TX is not already inserted in an unconfirmed state, the balances will be wonky when the TX is confirmed.
Like #387 the patch is to first quickly update the "unconfirmed" data for a TX before proceeding (in the case where txdb sees a TX for the very first time, in a block)