Conversation
Signed-off-by: sys_bbsycl <sys_bbsycl@nnlocl110.inn.intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
Signed-off-by: Faceless_Account_bb-sycl <bb-sycl@intel.com>
hanzhan1
pushed a commit
that referenced
this pull request
Dec 10, 2020
…e tools This is the #1 of 2 changes that make remarks hotness threshold option available in more tools. The changes also allow the threshold to sync with hotness threshold from profile summary with special value 'auto'. This change modifies the interface of lto::setupLLVMOptimizationRemarks() to accept remarks hotness threshold. Update all the tools that use it with remarks hotness threshold options: * lld: '--opt-remarks-hotness-threshold=' * llvm-lto2: '--pass-remarks-hotness-threshold=' * llvm-lto: '--lto-pass-remarks-hotness-threshold=' * gold plugin: '-plugin-opt=opt-remarks-hotness-threshold=' Differential Revision: https://reviews.llvm.org/D85809
hanzhan1
pushed a commit
that referenced
this pull request
Dec 10, 2020
CXXDeductionGuideDecl with a local typedef has its own copy of the
TypedefDecl with the CXXDeductionGuideDecl as the DeclContext of that
TypedefDecl.
```
template <typename T> struct A {
typedef T U;
A(U, T);
};
A a{(int)0, (int)0};
```
Related discussion on cfe-dev:
http://lists.llvm.org/pipermail/cfe-dev/2020-November/067252.html
Without this fix, when we import the CXXDeductionGuideDecl (via
VisitFunctionDecl) then before creating the Decl we must import the
FunctionType. However, the first parameter's type is the afore mentioned
local typedef. So, we then start importing the TypedefDecl whose
DeclContext is the CXXDeductionGuideDecl itself. The infinite loop is
formed.
```
#0 clang::ASTNodeImporter::VisitCXXDeductionGuideDecl(clang::CXXDeductionGuideDecl*) clang/lib/AST/ASTImporter.cpp:3543:0
#1 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) /home/egbomrt/WORK/llvm5/build/debug/tools/clang/include/clang/AST/DeclNodes.inc:405:0
#2 clang::ASTImporter::ImportImpl(clang::Decl*) clang/lib/AST/ASTImporter.cpp:8038:0
#3 clang::ASTImporter::Import(clang::Decl*) clang/lib/AST/ASTImporter.cpp:8200:0
#4 clang::ASTImporter::ImportContext(clang::DeclContext*) clang/lib/AST/ASTImporter.cpp:8297:0
#5 clang::ASTNodeImporter::ImportDeclContext(clang::Decl*, clang::DeclContext*&, clang::DeclContext*&) clang/lib/AST/ASTImporter.cpp:1852:0
#6 clang::ASTNodeImporter::ImportDeclParts(clang::NamedDecl*, clang::DeclContext*&, clang::DeclContext*&, clang::DeclarationName&, clang::NamedDecl*&, clang::SourceLocation&) clang/lib/AST/ASTImporter.cpp:1628:0
intel#7 clang::ASTNodeImporter::VisitTypedefNameDecl(clang::TypedefNameDecl*, bool) clang/lib/AST/ASTImporter.cpp:2419:0
intel#8 clang::ASTNodeImporter::VisitTypedefDecl(clang::TypedefDecl*) clang/lib/AST/ASTImporter.cpp:2500:0
intel#9 clang::declvisitor::Base<std::add_pointer, clang::ASTNodeImporter, llvm::Expected<clang::Decl*> >::Visit(clang::Decl*) /home/egbomrt/WORK/llvm5/build/debug/tools/clang/include/clang/AST/DeclNodes.inc:315:0
intel#10 clang::ASTImporter::ImportImpl(clang::Decl*) clang/lib/AST/ASTImporter.cpp:8038:0
intel#11 clang::ASTImporter::Import(clang::Decl*) clang/lib/AST/ASTImporter.cpp:8200:0
intel#12 llvm::Expected<clang::TypedefNameDecl*> clang::ASTNodeImporter::import<clang::TypedefNameDecl>(clang::TypedefNameDecl*) clang/lib/AST/ASTImporter.cpp:165:0
intel#13 clang::ASTNodeImporter::VisitTypedefType(clang::TypedefType const*) clang/lib/AST/ASTImporter.cpp:1304:0
intel#14 clang::TypeVisitor<clang::ASTNodeImporter, llvm::Expected<clang::QualType> >::Visit(clang::Type const*) /home/egbomrt/WORK/llvm5/build/debug/tools/clang/include/clang/AST/TypeNodes.inc:74:0
intel#15 clang::ASTImporter::Import(clang::QualType) clang/lib/AST/ASTImporter.cpp:8071:0
intel#16 llvm::Expected<clang::QualType> clang::ASTNodeImporter::import<clang::QualType>(clang::QualType const&) clang/lib/AST/ASTImporter.cpp:179:0
intel#17 clang::ASTNodeImporter::VisitFunctionProtoType(clang::FunctionProtoType const*) clang/lib/AST/ASTImporter.cpp:1244:0
intel#18 clang::TypeVisitor<clang::ASTNodeImporter, llvm::Expected<clang::QualType> >::Visit(clang::Type const*) /home/egbomrt/WORK/llvm5/build/debug/tools/clang/include/clang/AST/TypeNodes.inc:47:0
intel#19 clang::ASTImporter::Import(clang::QualType) clang/lib/AST/ASTImporter.cpp:8071:0
intel#20 llvm::Expected<clang::QualType> clang::ASTNodeImporter::import<clang::QualType>(clang::QualType const&) clang/lib/AST/ASTImporter.cpp:179:0
intel#21 clang::QualType clang::ASTNodeImporter::importChecked<clang::QualType>(llvm::Error&, clang::QualType const&) clang/lib/AST/ASTImporter.cpp:198:0
intel#22 clang::ASTNodeImporter::VisitFunctionDecl(clang::FunctionDecl*) clang/lib/AST/ASTImporter.cpp:3313:0
intel#23 clang::ASTNodeImporter::VisitCXXDeductionGuideDecl(clang::CXXDeductionGuideDecl*) clang/lib/AST/ASTImporter.cpp:3543:0
```
The fix is to first create the TypedefDecl and only then start to import
the DeclContext.
Basically, we could do this during the import of all other Decls (not
just for typedefs). But it seems, there is only one another AST
construct that has a similar cycle: a struct defined as a function
parameter:
```
int struct_in_proto(struct data_t{int a;int b;} *d);
```
In that case, however, we had decided to return simply with an error
back then because that seemed to be a very rare construct.
Differential Revision: https://reviews.llvm.org/D92209
hanzhan1
pushed a commit
that referenced
this pull request
Dec 22, 2020
CONFLICT (content): Merge conflict in llvm/lib/Transforms/IPO/PassManagerBuilder.cpp
hanzhan1
pushed a commit
that referenced
this pull request
Dec 22, 2020
This reverts commit bfd2c21. This appears to be causing stage2 msan failures on buildbots: FAIL: LLVM :: Transforms/SimplifyCFG/X86/bug-25299.ll (65872 of 71835) ******************** TEST 'LLVM :: Transforms/SimplifyCFG/X86/bug-25299.ll' FAILED ******************** Script: -- : 'RUN: at line 1'; /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/opt < /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/Transforms/SimplifyCFG/X86/bug-25299.ll -simplifycfg -S | /b/sanitizer-x86_64-linux-fast/build/llvm_build_msan/bin/FileCheck /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/test/Transforms/SimplifyCFG/X86/bug-25299.ll -- Exit Code: 2 Command Output (stderr): -- ==87374==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x9de47b6 in getBasicBlockIndex /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/include/llvm/IR/Instructions.h:2749:5 #1 0x9de47b6 in simplifyCommonResume /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:4112:23 #2 0x9de47b6 in simplifyResume /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:4039:12 #3 0x9de47b6 in (anonymous namespace)::SimplifyCFGOpt::simplifyOnce(llvm::BasicBlock*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6330:16 #4 0x9dcca13 in run /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6358:16 #5 0x9dcca13 in llvm::simplifyCFG(llvm::BasicBlock*, llvm::TargetTransformInfo const&, llvm::SimplifyCFGOptions const&, llvm::SmallPtrSetImpl<llvm::BasicBlock*>*) /b/sanitizer-x86_64-linux-fast/build/llvm-project/llvm/lib/Transforms/Utils/SimplifyCFG.cpp:6369:8 #6 0x974643d in iterativelySimplifyCFG(
hanzhan1
pushed a commit
that referenced
this pull request
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.