Skip to content

Fix ResetPackageAsync throwing NotImplementedException #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Draft

Fix ResetPackageAsync throwing NotImplementedException #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604848b
Initial plan for issue
Copilot May 22, 2025
2682452
Fix ResetPackageAsync throwing NotImplementedException
Copilot May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified BuildAll.cmd
100644 → 100755
View file
Open in desktop
Empty file.
11 changes: 8 additions & 3 deletions dev/PackageManager/API/M.W.M.D.PackageDeploymentManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,9 +169,14 @@ namespace winrt::Microsoft::Windows::Management::Deployment::implementation
}
case winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentFeature::ResetPackage:
{
//TODO Awaiting Windows update
//return ::WindowsVersion::IsExportPresent(L"appxdeploymentclient.dll", "MsixResetPackageAsync");
return false;
BOOL isSupported{};
const HRESULT hr{ PackageManagement_IsFeatureSupported(L"ResetPackage", &isSupported) };
if (hr == E_NOTIMPL)
{
return false;
}
THROW_IF_FAILED_MSG(hr, "ResetPackage");
return !!isSupported;
}
case winrt::Microsoft::Windows::Management::Deployment::PackageDeploymentFeature::RepairPackage:
{
Expand Down