ci(pdf): quote GITHUB_ENV and GITHUB_OUTPUT redirects flagged by actionlint SC2086 - #126
Merged
Merged
Conversation
actionlint reported seven SC2086 findings across on-pull-request.yml, publish.yml and test.yml, all of them writes to the runner-provided $GITHUB_ENV / $GITHUB_OUTPUT paths with an unquoted redirect target. Quote the redirect targets. This is the same pattern already applied to changeset-check.yml in #122, which was scoped to #121 and left these alone. Lint hygiene only, no behavioural change: none of these scripts consume untrusted input, and actionlint reports no "potentially untrusted" findings in these three files. Closes #125
Contributor
Release PreviewThis PR title will not trigger an automatic release on squash merge. Use a releaseable conventional PR title like Otherwise, add a manual changeset or apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quotes the seven unquoted
$GITHUB_ENV/$GITHUB_OUTPUTredirect targets thatactionlintflags as SC2086 across three workflows.This is the same pattern already applied to
changeset-check.ymlin #122, whichwas scoped to #121 and deliberately left the rest alone.
Changes
on-pull-request.ymlSTORE_PATH=…→>> "$GITHUB_ENV"on-pull-request.ymlbump=$bump→>> "$GITHUB_OUTPUT"publish.ymlSTORE_PATH=…→>> "$GITHUB_ENV"publish.ymlchanged=false→>> "$GITHUB_OUTPUT"publish.ymlchanged=true→>> "$GITHUB_OUTPUT"publish.ymlversion=…→>> "$GITHUB_OUTPUT"test.ymlSTORE_PATH=…→>> "$GITHUB_ENV"Scope
Lint hygiene only; no behavioural change. None of these scripts consume untrusted
input —
actionlintreports nois potentially untrustedfindings in these threefiles. The security-relevant untrusted-input finding lives in
changeset-check.ymland is tracked by #121 / #122.
Verification
actionlintbefore and after, from this branch:changeset-check.yml.changeset-check.yml(SC2086 + untrusted PR title),which ci: pass untrusted pull-request fields through env in changeset-check #122 fixes. Zero findings remain in the three files this PR touches.
pnpm typecheck,pnpm lint,pnpm test(162 passed / 17 files) andpnpm buildare all green.
pnpm docs:apiwas not run — no public API or JSDoc surface changed.Release intent
Labelled
skip-changeset: the diff touches only.github/workflows/**, norelease-sensitive path, and the commit subject is non-releaseable.
Closes #125
{ "schema": "hv-agent-run:v1", "runtime": "claude", "session": "dca0aa48-4946-43ba-940b-51143a9e4a8b", "issue": "https://github.com/happyvertical/pdf/issues/125", "policy_revision": "1.0.0", "validation": [ "actionlint", "pnpm typecheck", "pnpm lint", "pnpm test", "pnpm build" ] }