ci(github-actions): replace retired macos-13 runner label with macos-15-intel by willgriffin · Pull Request #1186 · happyvertical/sdk

willgriffin · 2026-08-05T18:11:54Z

{
  "schema": "hv-agent-run:v1",
  "runtime": "kimi",
  "session": "cricket-kimi-20260805-pr1180-repair",
  "issue": "https://github.com/happyvertical/sdk/issues/1185",
  "policy_revision": "1.0.0",
  "validation": [
    "node --test scripts/validate-workflow-runners.test.mjs - 4/4 pass (red before fix)",
    "node --test scripts/*.test.mjs - 30/32 pass; 2 failures reproduce on clean origin/main (missing pnpm install artifacts), pre-existing",
    "actionlint v1.7.12 with CI flags on all 21 workflows - zero errors",
    "yamllint -c .github/.yamllint.yml on changed workflow - clean"
  ]
}

Summary

Replaces the retired macos-13 GitHub-hosted runner label with macos-15-intel for the x86_64-apple-darwin native build matrix entry in .github/workflows/build-json-native.yml.
Adds scripts/validate-workflow-runners.mjs + validate-workflow-runners.test.mjs (wired into pnpm test:ci-scripts) as a regression guard: it fails when any workflow references a retired GitHub-hosted runner label.

Root cause

Validate Workflow Files downloads the latest actionlint at run time. GitHub retired the macos-13 runner image, so actionlint v1.7.12 rejects the label and every PR touching .github/workflows/* fails the gate — observed on Renovate rollup #1180 (run 30731126697, job 91451642775) and reproduced locally against origin/main. Independently, the darwin-x64 native build could never schedule on the retired label.

Validation

Regression test red before the fix (build-json-native.yml:44 macos-13), green after: node --test scripts/validate-workflow-runners.test.mjs → 4/4 pass.
node --test scripts/*.test.mjs → 30/32 pass; the 2 failures (validate-publish-packages, vitest-config) reproduce identically on a clean origin/main worktree without these changes (missing pnpm install artifacts) — pre-existing, unrelated.
Latest actionlint v1.7.12 with -config-file .github/actionlint.yaml -ignore 'SC2086|SC2094|SC2129' (the exact CI invocation): zero errors across all 21 workflows.
yamllint -c .github/.yamllint.yml .github/workflows/build-json-native.yml → clean (the CI invocation).

Refs #1185 — remaining acceptance criteria (syncing dependency-updates to main, Renovate rebase of #1180) are tracked there and require this fix to merge first.

Notes

No package code changed; ci/test commits are non-releaseable, so no changeset.
Does not close ci: repair all-red Renovate rollup #1180 — stale dependency-updates base and retired macos-13 runner label #1185: the dependency-updates base sync must follow after merge.

…15-intel GitHub retired the macos-13 hosted runner image: the latest actionlint downloaded by Validate Workflow Files rejects the label (failing every PR that touches workflow files, e.g. Renovate rollup #1180), and the darwin-x64 native build could never schedule. macos-15-intel is the current GitHub-hosted Intel macOS label for the x86_64-apple-darwin target. Adds scripts/validate-workflow-runners.mjs plus a node:test regression guard wired into test:ci-scripts that fails when any workflow references a retired GitHub-hosted runner label. Refs #1185

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7619c7047f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-05T18:16:18Z

+    const matrixOs = text.match(/^\s*-?\s*os:\s*(.+?)\s*$/);
+    if (matrixOs) {
+      const label = matrixOs[1].replace(/^['"]|['"]$/g, '');
+      if (label && !label.includes('${{')) {
+        found.push({ line: index + 1, label });


Parse matrix OS arrays before checking runner labels

When a workflow uses the common matrix shorthand with runs-on: ${{ matrix.os }} and matrix.os: [ubuntu-22.04, macos-13], this regex captures the entire bracketed array as one label instead of checking each element, so isRetiredRunnerLabel never sees macos-13 and the new repository guard passes while a retired runner remains. Parse flow/block matrix arrays the same way as runs-on arrays, or use a YAML parser, so the check covers all static matrix labels it is meant to guard.

Useful? React with 👍 / 👎.

Review of the retired-label guard found three false negatives: flow-list matrix os axes, trailing inline comments on scalars, and block-sequence runs-on lists. Parse all three forms, strip inline comments, and add windows-2016 to the retired blocklist; document that the list needs a manual bump on future GitHub retirements with actionlint as backstop. Refs #1185

Final review found the block-region handler missed matrix os keys with empty values and YAML block sequences whose items sit at the same indentation as the key. Enter the block region for empty os: values and accept items at indentation >= the key's. Refs #1185

…ents Verification found a block region swallowed a following '- os: <label>' matrix include entry as a literal label, masking a retired label, and that blank or comment-only lines ended block sequences early. Let dash items that open an os: mapping fall through to the matrix matcher, skip blank/comment lines inside block regions, and rewrite the os: key regex with horizontal-whitespace classes to remove quadratic backtracking. Refs #1185

github-actions · 2026-08-05T18:39:38Z

📦 Version Bump Preview

When this PR is merged into main, packages will receive a patch version bump based on your conventional commits.

What happens on merge?

Tests run on the main branch
Packages are built
Versions are bumped automatically
The release commit is pushed back to main
Packages are published to public npm
Git tags are created

The horizontal-whitespace regexes no longer matched lines terminated by CRLF, silently missing retired labels in valid CRLF workflow files. Normalize line endings once before splitting so every matcher sees LF. Refs #1185

Bring branch up to date with main after PR #1182 (video-generation jobs) landed. No conflicts: this branch touches .github/workflows/build-json-native.yml and scripts/validate-workflow-runners.*, while #1182 touches packages/ai/*.

willgriffin mentioned this pull request Aug 5, 2026

chore(deps): update weekly dependency update #1180

Open

1 task

chatgpt-codex-connector Bot reviewed Aug 5, 2026

View reviewed changes

Cricket (Kimi) added 3 commits August 5, 2026 12:19

Cricket (Kimi) added 2 commits August 5, 2026 12:40

test(ci): normalize CRLF before scanning workflow runner labels

f41a024

The horizontal-whitespace regexes no longer matched lines terminated by CRLF, silently missing retired labels in valid CRLF workflow files. Normalize line endings once before splitting so every matcher sees LF. Refs #1185

Merge origin/main into kimi/1185-macos-runner-label

d82511c

Bring branch up to date with main after PR #1182 (video-generation jobs) landed. No conflicts: this branch touches .github/workflows/build-json-native.yml and scripts/validate-workflow-runners.*, while #1182 touches packages/ai/*.

willgriffin mentioned this pull request Aug 5, 2026

ci: repair all-red Renovate rollup #1180 — stale dependency-updates base and retired macos-13 runner label #1185

Closed

5 tasks

willgriffin added this pull request to the merge queue Aug 5, 2026

Merged via the queue into main with commit ded4331 Aug 5, 2026
19 checks passed

Navigation Menu

Uh oh!

ci(github-actions): replace retired macos-13 runner label with macos-15-intel - #1186

ci(github-actions): replace retired macos-13 runner label with macos-15-intel#1186
willgriffin merged 6 commits into
mainfrom
kimi/1185-macos-runner-label

willgriffin commented Aug 5, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

willgriffin commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Root cause

Validation

Notes

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 5, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 5, 2026

📦 Version Bump Preview

What happens on merge?

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

willgriffin commented Aug 5, 2026 •

edited

Loading