fix(deps): restore brace-expansion's lower advisory bound - #2205
fix(deps): restore brace-expansion's lower advisory bound#2205willgriffin wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbe4f89913
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
Updates root pnpm overrides to ensure undici and fast-uri are pinned to patched versions after their advisories’ vulnerable ranges expanded, unblocking the high-severity dependency audit gate across PRs and main.
Changes:
- Update the
undicioverride to pin7.29.0(patched for GHSA-4cwx-7wf7-3272). - Update the
fast-urioverride to pin3.1.5(patched for GHSA-7p8r-x3mc-p8w7). - Regenerate
pnpm-lock.yamlto reflect the new override targets and resolved transitive versions.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Adjusts root overrides for undici and fast-uri to pinned patched versions. |
| pnpm-lock.yaml | Lockfile refresh reflecting the new override selectors and resolved versions. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
pnpm-workspace.yaml:64
- The override selector is broader than the advisory range.
fast-uri@<3.1.5would also apply to any <3.0.0 versions (if they ever appear), potentially introducing an unintended major bump. Matching the advisory range (>=3.0.0 <3.1.5) aligns with AGENTS.md guidance and keeps the override narrowly targeted.
'fast-uri@<3.1.5': 3.1.5
GHSA-rgw5-rvv9-x895 starts at brace-expansion 4.0.0, but #2203 widened the selector to a bare `@<5.0.9`, which also matches every 1.x, 2.x, and 3.x dependency. A consumer of an older major would be forced onto 5.0.9 — an unrelated breaking upgrade for a release outside the advisory. Both reviewers raised this against the identical selectors in #2205; the undici and fast-uri cases landed separately in #2210 with their advisory lower bounds intact. This applies the same correction to the third one. Fixing the upper bound is what keeps the override from going stale as the advisory widens; keeping the lower bound is what stops it reaching past the advisory. The two are independent and both are required. Verified neutral: `pnpm audit` reports `1 low | 6 moderate` before and after, brace-expansion appears in neither report, and the only lockfile change is the mirrored override key — no package resolution moves. Closes #2204
bbe4f89 to
bc4efef
Compare
|
Removed from the merge queue — reason: CI_FAILURE A required status check went red on the merge-group head. Open the linked run and read the failing leaf job (shard), not the rollup — the rollup only mirrors it. Latest merge-group validation run for this PR: https://github.com/happyvertical/smrt/actions/runs/31043921215 merge-queue-watchdog: dequeue events are otherwise invisible; this comment makes queue ejections diagnosable (#2197). |
{"schema":"hv-agent-run:v1","runtime":"claude","session":"8a94e288-0358-403f-a3a6-8e81a80e6c5d","issue":"2204","head_sha":"4ff760d21e7ea7b4a119c2c9d1f7c7e1272461fd","policy_revision":"1.0.0","status":"complete"}Summary
Why
GHSA-rgw5-rvv9-x895 is
>=4.0.0 <5.0.9. #2203 fixed that override's upper bound (it had been pinned to5.0.8, the release the advisory later grew to cover) but dropped the lower bound entirely, so the bare@<5.0.9also matches every 1.x, 2.x, and 3.x dependency. Any consumer of an older major would be forced onto 5.0.9 — a breaking upgrade for a release outside the advisory.Both bounds matter, independently:
pnpm-workspace.yamleven carries a comment noting minimatch 9 was the last consumer of brace-expansion 2.x — precisely the range the bare selector would have captured.Validation
pnpm audit:1 low | 6 moderatebefore and after — verified against unmodifiedmain. Zerohigh, so the CI gate passesbrace-expansionappears in neither report, so narrowing resurfaces nothingpnpm audit:policy: green — 5 accepted records, 0 suppressionsStill stale, not fixed here
'postcss@<=8.5.17': 8.5.18has the same expired-upper-bound shape — its advisory is now<=8.5.22. It surfaces as a moderate, so it does not fail the gate; flagging rather than folding it into this PR.Closes #2204