feat(precompiles): implement UCDAO precompile#409
Closed
n1n3b1t wants to merge 16 commits intohaqq-network:pre/v1.9.xfrom
Closed
feat(precompiles): implement UCDAO precompile#409n1n3b1t wants to merge 16 commits intohaqq-network:pre/v1.9.xfrom
n1n3b1t wants to merge 16 commits intohaqq-network:pre/v1.9.xfrom
Conversation
n1n3b1t
requested review from
VorobevSA,
Yurist-85 and
onsails
as code owners
- Extract asSendAuthorization helper for type assertion pattern - Add helper functions for event emission with two addresses - Refactor executeTransfer with checkAndUpdateAuthorization and validateSpendLimit helpers - Simplify ParseFundArgs by removing intermediate variable - Remove unused ErrDifferentOriginFromOwner error constant Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days-before-close if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x0000000000000000000000000000000000000805Changes
x/evm/types/precompiles.go- Added UcdaoPrecompileAddress constantx/evm/types/params.go- Added to DefaultStaticPrecompilesx/evm/keeper/static_precompiles.go- Registered precompilex/ucdao/keeper/keeper.go- Added IsModuleEnabled to Keeper interfaceapp/app.go- Added keeper parameter to precompile initprecompiles/ucdao/*- Full precompile implementation (9 files)Test Plan
go test ./precompiles/ucdao/...)