Kb/feature/add tactile sensing and haptic feedback#7
Conversation
Juliaj
left a comment
There was a problem hiding this comment.
Overall the code looks good to me. This is a good addition to the original upstream repo, let's add it to FORK.md. In terms of location, how do you feel about moving Sensors to under src ? Moving it there make it easier to release this as standalone Python package for other applications to reuse.
There are some Python styling issues which our pre-commit wasn't able to catch. We also missed this with previous check-in. I am planning to fix them after your PR, changes are parked at branch jj/refactor/enhance_ruff_check.
| |---|---| | ||
| | Camera | https://www.amazon.com/dp/B0CLRJZG8D | | ||
| | AD/DA Expansion Hat | https://www.amazon.com/dp/B09Q8Y5F7Y | | ||
| | Haptic Motors | https://www.amazon.com/dp/B0FX9HW33Z | |
There was a problem hiding this comment.
This motor is out of stock. Is this a good replacement https://www.amazon.com/Vibration-9000RPM-Replacement-Arduino-Projects/dp/B08GPMCP7J/140-3617096-9051911?psc=1 ?
Adds initial support for FSR-based tactile sensing and haptic coin motor feedback.
Changes:
Initial scripts for haptic coin motor and tactile FSR sensor
Haptic test script
Resolved PySide6 dependency
Bug fixes in tactile sensing
Updated README with setup instructions and BOM
Added sensor dependencies to pixi.lock and updated CI