✨ feat(mq-lint): add mq-lint crate with LintRule trait#1913
Merged
Conversation
harehare
force-pushed
the
feat/mq-lint
branch
2 times, most recently
from
473348d to
a8ec171
Compare
Add new mq-lint crate providing the linting infrastructure and empty rule implementations for all 28 rules defined in mq-lint-rules.md. - LintRule trait with id(), severity(), check() - Diagnostic, LintContext, Linter, Severity types in lib.rs - LintConfig with per-rule enable/disable and complexity thresholds - Rule stubs organized into 5 categories (no mod.rs): correctness/ (10 rules), style/ (9 rules), complexity/ (5 rules), selector/ (5 rules), module/ (4 rules)
Implement 15 lint rules across correctness, style, complexity, and selector categories: Correctness: - unused_variable, unused_function, unused_import - unreachable_code, infinite_loop, duplicate_match_arm - shadow_variable, missing_else_in_expr, always_true_condition Style: - prefer_let_over_var, naming_convention, boolean_comparison - redundant_boolean_literal, prefer_specific_heading Complexity: - function_too_long, too_many_params, deeply_nested - too_many_match_arms, complex_interpolation Selector: - inefficient_selector, missing_depth_guard Also fix mq-hir selector_from_cst_node to map DoubleDot tokens to Selector::Recursive so that `..` creates a proper HIR symbol. Add LintContext::all_symbols() helper to cover symbols registered via insert_symbol (Variable, Selector, Ref, Keyword) that are not visible through symbols_for_source(). Add README.md for the mq-lint crate with usage examples, rule tables, and architecture overview. ✨ feat(mq-lint): implement remaining rules and wire lint into mq-lsp Implements check() logic for the rules that were previously stubs (ambiguous_qualified_access, missing_module_doc, selector_always_empty, prefer_coalesce, prefer_pipe_style, redundant_try) and drops rules that were out of scope for this pass (unused_catch_binding, circular_import, reexport_private, deprecated_selector, env_var_in_selector, unnecessary_parens). Packages mq-lint as a standalone CLI binary and adds --enable-lint/--disable-lint-rule support to mq-lsp, surfaced in the VS Code, Neovim, and Zed clients.
… enums Introduce RuleId (unit enum) and LintMessage (data-carrying enum) in mq-lint/src/message.rs so every rule has a compile-time-checked id and message/help text, instead of scattered string literals and format! calls across 27 rule files. Diagnostic now derives rule_id()/message()/ help() from a single LintMessage value. Update mq-lsp accordingly: Diagnostic::new(...) calls, rule_id comparisons, and disable_rule/is_rule_enabled now use RuleId instead of &str.
Configuration list referenced the stale mq-lsp.* prefix and omitted typeCheck/lint/enableCodeLens settings already present in package.json.
…_category function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.