Feat/add vocab#57
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix mistranslated or misclassified bundled-core entries in the new vocabulary additions and keep the reviewed batch changes together. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Correct the missed peacefulness abstract-noun classification and sync the batch notes with the applied audit result. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Fix oversimplification gloss and ruminate distractor group. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Refine locket, gangly, and lanky after code review. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Adjust reviewed meanings and distractor groups for the latest additions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 57 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR updates documentation and task planning files to reflect a vocabulary expansion from approximately 8,000 to 10,000 words. Changes include a new release version entry in the changelog, updated vocabulary counts in README files, and new task specifications and checklists for vocabulary batch processing (seed ranges 31000-37000). Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
There was a problem hiding this comment.
Devin Review found 1 potential issue.
🐛 1 issue in files not directly in the diff
🐛 CoreWordsVersion not bumped — existing users will not receive ~2127 new vocabulary words (internal/dict/embed.go:9)
The PR adds 2127 new entries to assets/words_core.jsonl (from 8038 to 10165 lines), but internal/dict/embed.go:9 still has CoreWordsVersion = "2026-04-11-leipzig-wnjpn-core-8k-v16". The SeedWords function at internal/store/migrate.go:82-84 short-circuits with return nil when currentVersion == version, so existing users whose database already stores this version string will never receive the new words. Only fresh installs will get the full 10165-word dictionary. The doctor diagnostic (internal/store/doctor.go:199) will also fail to flag the mismatch. This completely defeats the purpose of the PR for any upgrading user.
View 2 additional findings in Devin Review.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Summary by CodeRabbit