Skip to content

[e2e] fix VM's image creation#2538

Merged
khushboo-rancher merged 3 commits intoharvester:mainfrom
lanfon72:apiclient
Mar 31, 2026
Merged

[e2e] fix VM's image creation#2538
khushboo-rancher merged 3 commits intoharvester:mainfrom
lanfon72:apiclient

Conversation

@lanfon72
Copy link
Copy Markdown
Member

Which issue(s) this PR fixes:

Following fix for issue #2524, #2527, #2530

What this PR does / why we need it:

Add image uid for existing test cases of VM.

Special notes for your reviewer:

  1. Update managers' support version to rc1 as v1.8.0-rcX < v1.8.0.
  2. Adjust VM model to inject image_uid more eariler.
  3. Update image fixtures and add image_uid when we use vm.add_image.

Additional documentation or context

N/A

Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
@lanfon72 lanfon72 requested a review from a team March 26, 2026 18:18
@lanfon72 lanfon72 self-assigned this Mar 26, 2026
Copy link
Copy Markdown
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should folowing calls need modify too?

/workspaces/tests $ grep -P '\.add_image\(\S+?,\s*\S+?\s*\)' -r ./*
./harvester_e2e_tests/integrations/test_1_volumes.py:    vm_spec.add_image(vm_name, ubuntu_image["id"])
./harvester_robot_tests/libs/vm/rest.py:            vm_spec.add_image("disk-0", image_id)

@lanfon72
Copy link
Copy Markdown
Member Author

Should folowing calls need modify too?

/workspaces/tests $ grep -P '\.add_image\(\S+?,\s*\S+?\s*\)' -r ./*
./harvester_e2e_tests/integrations/test_1_volumes.py:    vm_spec.add_image(vm_name, ubuntu_image["id"])
./harvester_robot_tests/libs/vm/rest.py:            vm_spec.add_image("disk-0", image_id)

1_volumes be updated in #2531, consider the merge order, I will update it if this PR is latter merged.

robot's test not be configured as daily run and... I think its implementation still discussing ? 💭

Copy link
Copy Markdown
Contributor

@albinsun albinsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@asc5543 asc5543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@khushboo-rancher khushboo-rancher merged commit d285947 into harvester:main Mar 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants