[e2e] fix VM's image creation#2538
Merged
khushboo-rancher merged 3 commits intoharvester:mainfrom Mar 31, 2026
Merged
Conversation
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
Signed-off-by: Lanfon Fan <lanfon.fan@suse.com>
albinsun
reviewed
Mar 30, 2026
Contributor
albinsun
left a comment
There was a problem hiding this comment.
Should folowing calls need modify too?
/workspaces/tests $ grep -P '\.add_image\(\S+?,\s*\S+?\s*\)' -r ./*
./harvester_e2e_tests/integrations/test_1_volumes.py: vm_spec.add_image(vm_name, ubuntu_image["id"])
./harvester_robot_tests/libs/vm/rest.py: vm_spec.add_image("disk-0", image_id)
Member
Author
robot's test not be configured as daily run and... I think its implementation still discussing ? 💭 |
khushboo-rancher
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Following fix for issue #2524, #2527, #2530
What this PR does / why we need it:
Add
image uidfor existing test cases of VM.Special notes for your reviewer:
rc1asv1.8.0-rcX<v1.8.0.image_uidmore eariler.image_uidwhen we usevm.add_image.Additional documentation or context
N/A