Conversation
-created components for the page and content
hashemJaber
left a comment
hashemJaber
left a comment
There was a problem hiding this comment.
Good code structure but please use an SVG for the icon resources/src
hashemJaber
left a comment
hashemJaber
left a comment
There was a problem hiding this comment.
Please swipe images with SVG's, thank you
NOTE: Good code structure
There was a problem hiding this comment.
If no use of a file or empty, dont upload 🙂
There was a problem hiding this comment.
Nice work 👍
If we could though, not necessary but to coincide with codebase convert vanilla CSS to tailwind framework use.
| </div> | ||
| {/* make h1 a div or not??? */} | ||
| {/* <h1>{title}</h1> */} | ||
| <div className={`settings-nav title-${title}`}>{title}</div> |
There was a problem hiding this comment.
works but can also maybe make this a span element and apply tailwind / CSS styling from there.
| return ( | ||
| <section onClick={clickhandle}> | ||
| <div className="horizontal-line mx-auto flex"> | ||
| <Image |
There was a problem hiding this comment.
Can use SVG's here rather than images as Hashem mentioned.
https://heroicons.com/
Account: Search Account
Settings: Search gear & ones with tooth are nice
Arrow: Search arrow
Utilize CSS / Tailwind once you use these SVG's to resize the components / elements
| 'use client'; | ||
| import './AccountManagement.css'; | ||
| import { useState } from 'react'; | ||
| import InputComponent from '@/components/SharedComponents/InputComponent'; |
There was a problem hiding this comment.
Remove unecessary / unused imports
| @@ -0,0 +1,55 @@ | |||
| 'use client'; | |||
| import './SettingsNav.css'; | |||
| import { useState } from 'react'; | |||
3 participants
SO-48