deps(docker): bump python from 3.12-slim to 3.14-slim in the docker-all group#561
deps(docker): bump python from 3.12-slim to 3.14-slim in the docker-all group#561dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the docker-all group with 1 update: python. Updates `python` from 3.12-slim to 3.14-slim --- updated-dependencies: - dependency-name: python dependency-version: 3.14-slim dependency-type: direct:production dependency-group: docker-all ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryThis PR updates the Docker base image from
Confidence Score: 3/5The base image update is clean, but the docker-requirements.txt hashes were generated against Python 3.12 and may not resolve correctly under Python 3.14, causing the image build to fail. The only file changed is the FROM line, which correctly pins the new image by SHA256. However, the project installs dependencies with --require-hashes, and any packages that shipped version-specific wheels for CPython 3.12 will not match under a 3.14 interpreter. This is a real build-time breakage risk that should be validated before merging. docker-requirements.txt (not in the diff) — its recorded hashes need to be regenerated against Python 3.14 to confirm the build still succeeds. Important Files Changed
Reviews (1): Last reviewed commit: "deps(docker): bump python in the docker-..." | Re-trigger Greptile |
| @@ -1,4 +1,4 @@ | |||
| FROM python:3.12-slim@sha256:3d5ed973e45820f5ba5e46bd065bd88b3a504ff0724d85980dcd05eab361fcf4 | |||
| FROM python:3.14-slim@sha256:c845af9399020c7e562969a13689e929074a10fd057acd1b1fad06a2fb068e97 | |||
There was a problem hiding this comment.
Pinned hashes in
docker-requirements.txt may not match Python 3.14 wheels
docker-requirements.txt is installed with --require-hashes, meaning every wheel (or sdist) must match a recorded hash. Wheels built for CPython 3.12 (tags like cp312-cp312-*) will not be offered by pip for a 3.14 interpreter, so pip will fall back to a source distribution or a different wheel — both of which will fail the hash check. The build will error at the pip install step rather than at runtime, but it means the image as written may not actually build until docker-requirements.txt is regenerated against 3.14.
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
The docker-requirements.txt hashes must be regenerated against Python 3.14 before this PR can be merged. Use: uv pip compile pyproject.toml --extra cisco --generate-hashes -o docker-requirements.txt| | Files Reviewed (1 file)
Reviewed by laguna-m.1-20260312:free · 2,796,725 tokens |
Bumps the docker-all group with 1 update: python.
Updates
pythonfrom 3.12-slim to 3.14-slimDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions