builder: check Org/OU ARNs during prepare#494
Open
lbajolet-hashicorp wants to merge 1 commit intomainfrom
Open
builder: check Org/OU ARNs during prepare#494lbajolet-hashicorp wants to merge 1 commit intomainfrom
lbajolet-hashicorp wants to merge 1 commit intomainfrom
Conversation
JenGoldstrich
previously approved these changes
Jul 17, 2024
Contributor
JenGoldstrich
left a comment
JenGoldstrich
left a comment
There was a problem hiding this comment.
LGTM largely, and is definitely an improvement from the current experience, nice work, I made two suggestions, feel free to take them or leave them
| name string | ||
| OrgARN []string | ||
| OUARN []string | ||
| expectErr bool |
Contributor
There was a problem hiding this comment.
I would consider extending this to check the specific error returned, since there's several different cases that could change and these tests wouldn't fail
Contributor
Author
There was a problem hiding this comment.
I'm less sure about this, I think checking if the configs provoke an error when expected is more important than the contents of those errors, so I'm tempted to leave it as-is, but please feel free to push back if you think it's important
When a builder accepts organisation or organisational unit ARNs as part of its config, we don't actually validate that the format matches what AWS accepts, leading to confusion among our users. This commit checks that the provided ARNs match the expected format before running the build, and tries to provide information on what to change in the configs so they succeed later.
lbajolet-hashicorp
force-pushed
the
org_ou_arn_validation_prepare
branch
from
37641d4 to
693fda7
Compare
JenGoldstrich
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a builder accepts organisation or organisational unit ARNs as part of its config, we don't actually validate that the format matches what AWS accepts, leading to confusion among our users.
This commit checks that the provided ARNs match the expected format before running the build, and tries to provide information on what to change in the configs so they succeed later.
Related to #492