refactor: centralize and consolidate benchmark targets

[jon-wang-ibm]

Summary

Centralizes and consolidates all benchmark targets: enforces a consistent method ordering, eliminates repeated cleanup and switch-statement boilerplate, modernizes Go idioms, and applies a uniform naming convention across all 50+ targets.

Changes

Method ordering

• All targets follow: const → init() → attack struct → config structs → ParseConfig → Setup → Target → Cleanup → GetTargetInfo → Flags → private helpers
• Attack struct field order: pathPrefix → header → body → roleName → action → config → logger → cleanup-only fields

Cleanup consolidation

• logging.go: single cleanupMount(logger, client, pathPrefix) that detects auth vs secret mounts from the path prefix (/v1/auth/ → /sys/auth/, otherwise → /sys/mounts/); affects 31 secret + 12 auth Cleanup bodies with one call

Setup consolidation

• utils.go: resolveMountPath(base, random) replaces 48 identical RandomMounts blocks across all targets; 44 go-uuid imports removed
• utils.go: writeStruct(client, path, in) folds structToMap + Logical().Write + both error checks into one call; 75 pairs replaced across 41 files
• Transit and GCPKMS: buildResult(client, secretPath, action, keyName, configData) extracts the repeated json.Marshal → return &{Type}{pathPrefix, header, body, logger} tail from every action arm; each arm now contains only its unique seeding logic

Switch statement reduction

• Target() switches: all multi-case switches restructured to build a default struct then patch only differing fields (identity, totp, sync_aws)
• Target() helpers: kvv1/kvv2 read()/write(), totp create()/generate()/read(), sync_aws events()/write()/read() all inlined into Target(); totp mutable keyIndex removed (was not concurrency-safe); replaced with rand.Int63() suffix per tick
• Setup() logger-name switches: typeKey field set in init() for transit, gcpkms, totp; Setup uses targetLogger.Named(t.typeKey) instead of a per-action switch
• GCPKMS Setup: redundant two-arm switch calling identical createKey in both arms collapsed to unconditional call
• GCP Target(): SecretType branch precomputed as targetURL in Setup; config dropped from attack struct

Modernization

• interface{} → any in command/base_flags.go (12 Get() methods) and config/config.go
• for i := 0; i < len(...) → for range / for i := range n in benchmark_targets.go and target_sync_aws.go
• ioutil.ReadFile → os.ReadFile; ioutil.Discard → io.Discard; io/ioutil removed
• strings import removed from 31 files where it was only used for the now-extracted cleanup pattern

Naming convention

• All targets follow target_[type]_[method] → [Method][Type]: target_auth_* → *Auth, target_secret_* → *Secret, target_sync_aws → AWSSync, target_sys_status → SysStatus
• Top-level configs: *AuthConfig / *SecretConfig (removed Test and Secret infixes from ~40 names)
• Sub-configs: <Engine><Subtype>Config applied uniformly; auth mount configs disambiguated to <Engine>AuthMountConfig where needed to avoid collision with the renamed top-level wrapper
• Transit sub-configs: word order fixed (TransitConfigSign → TransitSignConfig, etc.)
• GCPKMS sub-configs: Test infix replaced with Secret (GCPKMSSecretMountConfig, GCPKMSSecretEncryptConfig, etc.)

Correctness

• SecretIDNumUses typo fixed in approle
• log.Fatalf → return nil, fmt.Errorf in cert auth (3 calls); "log" import removed
• errCount → []error + errors.Join in benchmark target cleanup
• "POST"/"GET" string literals → named constants across all targets

TODOs as contracts

• benchmark_targets.go: GetTargetInfo collapse into ConfigureTarget — deferred; requires touching all 50+ targets
• benchmark_targets.go: single TestList registration per engine for transit/gcpkms/totp (identity pattern) — deferred; breaking HCL interface change (transit_sign → transit with action in config block)

Validation

go build ./...
go vet ./...
go test -race ./benchmarktests/... ./config/...